public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Nowa Ammerlaan <nowa@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH 4/5] linux-mod-r1.eclass: make modules_process_dracut.conf.d public
Date: Thu, 20 Mar 2025 09:25:59 +0100	[thread overview]
Message-ID: <cb612434-a278-4aba-a3c3-bac95de4179f@gentoo.org> (raw)
In-Reply-To: <ffe331ac-ba0c-42fa-86d4-4e897f1b43e3@gentoo.org>

On 19/03/2025 23:37, Eli Schwartz wrote:
> On 3/19/25 6:10 PM, Sam James wrote:
>> If we're doing it orphaned, it should be done as hooks instead rather
>> than with any integration in the ebuild, though. postinst / orphaned
>> files are broadly a hack. Orphaned files break a bunch of invariants
>> including Just Working for binpkgs properly.
>>
>> I also agree with Ionen that this is important enough that I'd want this
>> to be the primary path (and fully tested & supported), not done at
>> all. But wanting to support *both* long-time makes me uneasy.
> 
> 
> Shower thought, but if interested in guaranteeing a single tested path,
> it is possible to unconditionally prep the source tree for dkms, then
> have USE=dkms decide whether to:
> 
> - install the sources to /usr/src
> 
> - build the module in the ebuild and install it in src_install, via
>    running the `dkms build` command

Making the prepping (i.e. the creation/seding/moving of the dkms.conf 
files) unconditional is definitely doable.

I'm not sure about calling 'dkms build' in src_install. DKMS has some 
switches to move around the location of the module and dkms tree that we 
could in theory use to have it operate on the ED instead of the EROOT. 
But it does expect some files to be already there. Though perhaps we 
could solve this with some symlinks.

That being said, this would add more complexity, and we also run into 
the problem that sys-kernel/dkms is not keyworded everywhere (yet). 
Furthermore, we still keep the dkms USE flag, so fundamentally there are 
still two paths to test.


> This would mean making dkms a dependency as such:
> 
> BDEPEND="
>      !dkms? ( sys-kernel/dkms )
> "
> RDEPEND="
>      dkms? ( sys-kernel/dkms )
> "
> 
> I suppose that not everyone will necessarily like this. But it should be
> technically feasible, at least.
> 




  reply	other threads:[~2025-03-20  8:26 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 12:48 [gentoo-dev] [PATCH 1/5] use.desc: document new dkms flag Nowa Ammerlaan
2025-03-14 12:48 ` [gentoo-dev] [PATCH 2/5] profiles: mask dkms flag where not available Nowa Ammerlaan
2025-03-14 12:48 ` [gentoo-dev] [PATCH 3/5] linux-mod-r1.eclass: move modlist processing into separate func Nowa Ammerlaan
2025-03-14 12:48 ` [gentoo-dev] [PATCH 4/5] linux-mod-r1.eclass: make modules_process_dracut.conf.d public Nowa Ammerlaan
2025-03-14 16:23   ` Ionen Wolkens
2025-03-14 19:47     ` Nowa Ammerlaan
2025-03-15  3:56       ` Ionen Wolkens
2025-03-17 10:11         ` Nowa Ammerlaan
2025-03-17 10:25           ` Alexey Sokolov
2025-03-18  3:14           ` [gentoo-dev] " Duncan
2025-03-19  0:34             ` Ionen Wolkens
2025-03-19  0:56               ` Ionen Wolkens
2025-03-19  1:07               ` Ionen Wolkens
2025-03-19  7:57                 ` Nowa Ammerlaan
2025-03-19  8:48                   ` Ionen Wolkens
2025-03-19 12:41                     ` Nowa Ammerlaan
2025-03-19 22:10                   ` Sam James
2025-03-19 22:37                     ` Eli Schwartz
2025-03-20  8:25                       ` Nowa Ammerlaan [this message]
2025-03-20  8:12                     ` Nowa Ammerlaan
2025-03-19  3:05               ` Ionen Wolkens
2025-03-19 22:11             ` Sam James
2025-03-17 16:23         ` [gentoo-dev] " Eli Schwartz
2025-03-14 12:48 ` [gentoo-dev] [PATCH 5/5] dkms.eclass: introduce new eclass Nowa Ammerlaan
2025-03-14 15:34   ` Alexey Sokolov
2025-03-14 15:44     ` Nowa Ammerlaan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb612434-a278-4aba-a3c3-bac95de4179f@gentoo.org \
    --to=nowa@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox