From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass
Date: Wed, 12 Jul 2023 19:48:32 +0200 [thread overview]
Message-ID: <c9c4bce7c9c4604c5c736d34893a3f162ec9776b.camel@gentoo.org> (raw)
In-Reply-To: <uttu958mv@gentoo.org>
On Wed, 2023-07-12 at 19:42 +0200, Ulrich Mueller wrote:
> > > > > > On Wed, 12 Jul 2023, Michał Górny wrote:
>
> > + if [[ ${_CARGO_ECLASS} ]]; then
> > + filter-lto
> > + fi
>
> Testing for an internal variable of another eclass seems less than
> ideal. How about "has cargo ${INHERITED}" instead?
>
Sure, as long as it works.
--
Best regards,
Michał Górny
prev parent reply other threads:[~2023-07-12 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 12:22 [gentoo-dev] [PATCH 0/4] python eclasses: PyPy3.10 update + cargo LTO strip-flags Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 1/4] python-utils-r1.eclass: Require >=dev-python/pypy3-7.3.12 Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 2/4] python-utils-r1.eclass: pypy3 is now 3.10-only Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 3/4] distutils-r1.eclass: Update addpredict for PyPy3.10 Michał Górny
2023-07-12 12:22 ` [gentoo-dev] [PATCH 4/4] distutils-r1.eclass: Disable LTO when using cargo.eclass Michał Górny
2023-07-12 17:42 ` Ulrich Mueller
2023-07-12 17:48 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c4bce7c9c4604c5c736d34893a3f162ec9776b.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox