public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs
@ 2024-05-02 11:15 Michal Prívozník
  2024-05-02 20:48 ` Ben Kohler
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Prívozník @ 2024-05-02 11:15 UTC (permalink / raw)
  To: gentoo-dev

Hi,

I've noticed (thanks to an issue reported against Libvirt [1]), that
neither minimal installation ISO nor liveGUI ISO contain anything inside
their Primary Volume Descriptors that would hint the ISO contains
Gentoo. This is unfortunate a bit, because matching VolumeID is exactly
how tools like libosinfo detect distro on given ISO [2] and then can
recommend some values when creating VMs with that ISO. In this specific
case, minimal amount of memory required to even boot the ISO (yeah, it
currently reports 256MiB which is too small for anything really).

Is there any chance this could be fixed, e.g. by reporting something in
VolumeID?

Michal

1: https://gitlab.com/libvirt/libvirt/-/issues/600
2: https://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/gentoo.org/gentoo-rolling.xml.in?ref_type=heads



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs
  2024-05-02 11:15 [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs Michal Prívozník
@ 2024-05-02 20:48 ` Ben Kohler
  2024-05-03  8:43   ` Michal Prívozník
  0 siblings, 1 reply; 4+ messages in thread
From: Ben Kohler @ 2024-05-02 20:48 UTC (permalink / raw)
  To: Michal Prívozník; +Cc: gentoo-dev, gentoo-releng


On 5/2/24 06:15, Michal Prívozník wrote:
> Hi,
>
> I've noticed (thanks to an issue reported against Libvirt [1]), that
> neither minimal installation ISO nor liveGUI ISO contain anything inside
> their Primary Volume Descriptors that would hint the ISO contains
> Gentoo. This is unfortunate a bit, because matching VolumeID is exactly
> how tools like libosinfo detect distro on given ISO [2] and then can
> recommend some values when creating VMs with that ISO. In this specific
> case, minimal amount of memory required to even boot the ISO (yeah, it
> currently reports 256MiB which is too small for anything really).
>
> Is there any chance this could be fixed, e.g. by reporting something in
> VolumeID?
>
> Michal
>
> 1: https://gitlab.com/libvirt/libvirt/-/issues/600
> 2: https://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/gentoo.org/gentoo-rolling.xml.in?ref_type=heads
>
>
Hi Michal,

Thanks for bringing this to our attention.  Relatively recently, our ISO 
build tool catalyst started using grub-mkrescue to prepare the 
bootloaders and create the iso [1], and we seem to have lost the volume 
IDs at that time.  I've just added a -volid parameter back in [2] which 
should restore the volume IDs we were using before and should match what 
libosinfo is expecting.  The change should apply to our next weekly 
autobuilds.

Before: install-x86-minimal-20240429T170419Z.iso: ISO 9660 CD-ROM 
filesystem data (DOS/MBR boot sector) 'ISOIMAGE' (bootable)

After: install-x86-minimal-20240429T170419Z.iso: ISO 9660 CD-ROM 
filesystem data (DOS/MBR boot sector) 'Gentoo x86 20240429T170419Z' 
(bootable)

[1] 
https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=0a27a7a39a7d6944618009f8027fb09a22244c34

[2] 
https://gitweb.gentoo.org/proj/catalyst.git/commit/?id=04c70a9df505718c7e97ca1484f7c03270e6824c



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs
  2024-05-02 20:48 ` Ben Kohler
@ 2024-05-03  8:43   ` Michal Prívozník
  2024-05-03 11:32     ` Eli Schwartz
  0 siblings, 1 reply; 4+ messages in thread
From: Michal Prívozník @ 2024-05-03  8:43 UTC (permalink / raw)
  To: gentoo-dev, Ben Kohler; +Cc: gentoo-releng

On 5/2/24 22:48, Ben Kohler wrote:
> 
> On 5/2/24 06:15, Michal Prívozník wrote:
>> Hi,
>>
>> I've noticed (thanks to an issue reported against Libvirt [1]), that
>> neither minimal installation ISO nor liveGUI ISO contain anything inside
>> their Primary Volume Descriptors that would hint the ISO contains
>> Gentoo. This is unfortunate a bit, because matching VolumeID is exactly
>> how tools like libosinfo detect distro on given ISO [2] and then can
>> recommend some values when creating VMs with that ISO. In this specific
>> case, minimal amount of memory required to even boot the ISO (yeah, it
>> currently reports 256MiB which is too small for anything really).
>>
>> Is there any chance this could be fixed, e.g. by reporting something in
>> VolumeID?
>>
>> Michal
>>
>> 1: https://gitlab.com/libvirt/libvirt/-/issues/600
>> 2:
>> https://gitlab.com/libosinfo/osinfo-db/-/blob/main/data/os/gentoo.org/gentoo-rolling.xml.in?ref_type=heads
>>
>>
> Hi Michal,
> 
> Thanks for bringing this to our attention.  Relatively recently, our ISO
> build tool catalyst started using grub-mkrescue to prepare the
> bootloaders and create the iso [1], and we seem to have lost the volume
> IDs at that time.  I've just added a -volid parameter back in [2] which
> should restore the volume IDs we were using before and should match what
> libosinfo is expecting.  The change should apply to our next weekly
> autobuilds.

Awesome! Thank you.

And speaking of things that slip our attention. When trying to get a
link to this e-mail thread I've noticed at least gentoo-dev archives on
archives.gentoo.org are stuck in 2023:

  https://archives.gentoo.org/gentoo-dev/

I'm not sure where to report this, so I'm hoping this will find the
right recipient. Thanks once again.

Michal



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs
  2024-05-03  8:43   ` Michal Prívozník
@ 2024-05-03 11:32     ` Eli Schwartz
  0 siblings, 0 replies; 4+ messages in thread
From: Eli Schwartz @ 2024-05-03 11:32 UTC (permalink / raw)
  To: gentoo-dev


[-- Attachment #1.1.1: Type: text/plain, Size: 651 bytes --]

On 5/3/24 4:43 AM, Michal Prívozník wrote:
> Awesome! Thank you.
> 
> And speaking of things that slip our attention. When trying to get a
> link to this e-mail thread I've noticed at least gentoo-dev archives on
> archives.gentoo.org are stuck in 2023:
> 
>   https://archives.gentoo.org/gentoo-dev/
> 
> I'm not sure where to report this, so I'm hoping this will find the
> right recipient. Thanks once again.


Unfortunate but known issue: https://bugs.gentoo.org/903753

There's an experimental public-inbox instance at
https://public-inbox.gentoo.org/gentoo-dev/ with just the one mailing
list for now.


-- 
Eli Schwartz

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-05-03 11:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-02 11:15 [gentoo-dev] Gentoo identification in Primary Volume Descriptor of ISOs Michal Prívozník
2024-05-02 20:48 ` Ben Kohler
2024-05-03  8:43   ` Michal Prívozník
2024-05-03 11:32     ` Eli Schwartz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox