public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-dev] python-any-r1 deps used only for testing
@ 2018-02-28 22:03 Francesco Riosa
  2018-03-01  1:06 ` Thomas Deutschmann
  0 siblings, 1 reply; 2+ messages in thread
From: Francesco Riosa @ 2018-02-28 22:03 UTC (permalink / raw
  To: gentoo development

hi,
   sys-devel/automake would to depend on python:2.7 if and only if
"test" are enabled.

For the tast it inherit python-any-r1 eclass than depend conditionally
with test? ( ${PYTHON_DEPS} )"

Additionally the ebuild call python_setup() in src_test()

However this does not work, because eclass python-any-r1_pkg_setup()
call python_setup() itself and automake ebuild does NOT define it's own
pkg_setup() (thus python-any-r1 pkg setup is used).

Result is that with no python:2.7 installed ebuild will fail, always
both with test enabled or disabled.

I've realized all this after bug https://bugs.gentoo.org/648940 was
closed, that discussion didn't go very well, so I'd like to ask before
opening a different bug

It's correct to ask the maintainer to define pkg_setup() in automake ebuild?

if so should it be empty like:
pkg_setup() { : }
or it should contain default like
pkg_setup() { default }

or another solution is preferred?

Thanks in advance,
Francesco (vivo)




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [gentoo-dev] python-any-r1 deps used only for testing
  2018-02-28 22:03 [gentoo-dev] python-any-r1 deps used only for testing Francesco Riosa
@ 2018-03-01  1:06 ` Thomas Deutschmann
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Deutschmann @ 2018-03-01  1:06 UTC (permalink / raw
  To: gentoo-dev


[-- Attachment #1.1: Type: text/plain, Size: 772 bytes --]

On 2018-02-28 23:03, Francesco Riosa wrote:
> Result is that with no python:2.7 installed ebuild will fail, always
> both with test enabled or disabled.

Why haven't you posted this information in the bug?!


> I've realized all this after bug https://bugs.gentoo.org/648940 was
> closed, that discussion didn't go very well, [...]

Really? Thought

> Feel free to keep commenting if you think I am wrong. I'll be notified
> and read your comment.

was pretty clear that you can talk with me...

Anyway, fixed via
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cfaa5ec192519a74951fd57f05c483984e408e4b.
Thank you for the report.


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-01  1:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-28 22:03 [gentoo-dev] python-any-r1 deps used only for testing Francesco Riosa
2018-03-01  1:06 ` Thomas Deutschmann

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox