[gentoo-dev] [PATCH] meson.eclass: require at least meson-0.41.1

[gentoo-dev] [PATCH] meson.eclass: require at least meson-0.41.1

[Zac Medico]

Require newer meson in order to avoid build failures triggered
if >=meson-0.41.1 is not installed soon enough. For example,
I experienced bug 649264 because I upgraded xorg-proto and
libxshmfence packages before meson.

Fixes: https://bugs.gentoo.org/649264
---
 eclass/meson.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/meson.eclass b/eclass/meson.eclass
index f2202a04593..2523bec57ac 100644
--- a/eclass/meson.eclass
+++ b/eclass/meson.eclass
@@ -59,7 +59,7 @@ EXPORT_FUNCTIONS src_configure src_compile src_test src_install
 if [[ -z ${_MESON_ECLASS} ]]; then
 _MESON_ECLASS=1
 
-MESON_DEPEND=">=dev-util/meson-0.40.0
+MESON_DEPEND=">=dev-util/meson-0.41.1
 	>=dev-util/ninja-1.7.2"
 
 # @ECLASS-VARIABLE: MESON_AUTO_DEPEND
-- 
2.13.6

Re: [gentoo-dev] [PATCH] meson.eclass: require at least meson-0.41.1

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 1290 bytes --]

Ühel kenal päeval, P, 22.07.2018 kell 20:27, kirjutas Zac Medico:
> Require newer meson in order to avoid build failures triggered
> if >=meson-0.41.1 is not installed soon enough. For example,
> I experienced bug 649264 because I upgraded xorg-proto and
> libxshmfence packages before meson.
> 
> Fixes: https://bugs.gentoo.org/649264

Closes, not Fixes?

> ---
>  eclass/meson.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/eclass/meson.eclass b/eclass/meson.eclass
> index f2202a04593..2523bec57ac 100644
> --- a/eclass/meson.eclass
> +++ b/eclass/meson.eclass
> @@ -59,7 +59,7 @@ EXPORT_FUNCTIONS src_configure src_compile src_test
> src_install
>  if [[ -z ${_MESON_ECLASS} ]]; then
>  _MESON_ECLASS=1
>  
> -MESON_DEPEND=">=dev-util/meson-0.40.0
> +MESON_DEPEND=">=dev-util/meson-0.41.1

By my understanding this should be 0.44.1, not 0.41.1.
At least 0.43.0 is one of the broken versions.

0.44.1 is also the lowest available version in tree; raising
MESON_DEPEND to that would as a side-effect not require ebuilds to have
their own meson depend, when they need newer versions (>=0.41 was
common in gnome 3.26, might be >=0.44 in newer).

>  	>=dev-util/ninja-1.7.2"
>  
>  # @ECLASS-VARIABLE: MESON_AUTO_DEPEND

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

Re: [gentoo-dev] [PATCH] meson.eclass: require at least meson-0.41.1

[Zac Medico]

[-- Attachment #1.1: Type: text/plain, Size: 1403 bytes --]

On 07/23/2018 01:08 AM, Mart Raudsepp wrote:
> Ühel kenal päeval, P, 22.07.2018 kell 20:27, kirjutas Zac Medico:
>> Require newer meson in order to avoid build failures triggered
>> if >=meson-0.41.1 is not installed soon enough. For example,
>> I experienced bug 649264 because I upgraded xorg-proto and
>> libxshmfence packages before meson.
>>
>> Fixes: https://bugs.gentoo.org/649264
> 
> Closes, not Fixes?

Closes is more accurate, yes.

>> ---
>>  eclass/meson.eclass | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/eclass/meson.eclass b/eclass/meson.eclass
>> index f2202a04593..2523bec57ac 100644
>> --- a/eclass/meson.eclass
>> +++ b/eclass/meson.eclass
>> @@ -59,7 +59,7 @@ EXPORT_FUNCTIONS src_configure src_compile src_test
>> src_install
>>  if [[ -z ${_MESON_ECLASS} ]]; then
>>  _MESON_ECLASS=1
>>  
>> -MESON_DEPEND=">=dev-util/meson-0.40.0
>> +MESON_DEPEND=">=dev-util/meson-0.41.1
> 
> By my understanding this should be 0.44.1, not 0.41.1.
> At least 0.43.0 is one of the broken versions.

0.44.1 is what I meant to type, yes.

> 0.44.1 is also the lowest available version in tree; raising
> MESON_DEPEND to that would as a side-effect not require ebuilds to have
> their own meson depend, when they need newer versions (>=0.41 was
> common in gnome 3.26, might be >=0.44 in newer).

Great!
-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]

Re: [gentoo-dev] [PATCH] meson.eclass: require at least meson-0.41.1

[Mike Gilbert]

On Sun, Jul 22, 2018 at 11:27 PM Zac Medico <zmedico@gentoo.org> wrote:
>
> Require newer meson in order to avoid build failures triggered
> if >=meson-0.41.1 is not installed soon enough. For example,
> I experienced bug 649264 because I upgraded xorg-proto and
> libxshmfence packages before meson.
>
> Fixes: https://bugs.gentoo.org/649264

I suggest jumping to 0.45.1 (latest stable on all archs). Feel free to
push that.

Re: [gentoo-dev] [PATCH] meson.eclass: require at least meson-0.41.1

[Zac Medico]

[-- Attachment #1.1: Type: text/plain, Size: 628 bytes --]

On 07/23/2018 07:56 AM, Mike Gilbert wrote:
> On Sun, Jul 22, 2018 at 11:27 PM Zac Medico <zmedico@gentoo.org> wrote:
>>
>> Require newer meson in order to avoid build failures triggered
>> if >=meson-0.41.1 is not installed soon enough. For example,
>> I experienced bug 649264 because I upgraded xorg-proto and
>> libxshmfence packages before meson.
>>
>> Fixes: https://bugs.gentoo.org/649264
> 
> I suggest jumping to 0.45.1 (latest stable on all archs). Feel free to
> push that.

Pushed:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bbe649a35dc8e06e55abfdf8e98a743d1e50d5a0

-- 
Thanks,
Zac


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]