public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Eli Schwartz <eschwartz93@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] .github: Add pull request template
Date: Wed, 1 May 2024 10:54:54 -0400	[thread overview]
Message-ID: <c30e5ed1-d703-4332-87cf-7707560f74ab@gmail.com> (raw)
In-Reply-To: <cd882143-c714-4770-a16a-5102c64a2f27@gentoo.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 1588 bytes --]

On 5/1/24 10:38 AM, Maciej Barć wrote:
> Ionen, I think that regular contributors could skip this altogether. For
> example the person I'm mentoring I am sure would follow all requirements
> listed by mgorny and me (see my reply).


Regular contributors might not even be submitting via PRs at all. :P


>> On a side-note, I have nothing against having .github in the tree. Just
>> saying given I know not everyone is happy with that.
> 
> I think we should push more into "conforming" to standard of online
> software forges. Reminder that we STILL do not have any form of a README
> file. Not even one that would say "Hey look at https://gentoo.org/".
> Also no license link. Afaik all contribs are under GPL-2.


Every file has a copyright header:

# Distributed under the terms of the GNU General Public License v2


It's not clear to me what more you want than this, or who it would help.

A README could be useful to github I guess, but on the other hand the
main purpose of a README is to tell people who don't know what a
repository is for, what that repository is for. Would it basically
duplicate the contents of https://wiki.gentoo.org/wiki/Ebuild_repository
or is there something else you want to see in a README?

I don't think "Hey look at https://gentoo.org" is remotely useful as a
README, compared to what is already there:

[MIRROR] Official Gentoo ebuild repository
https://gitweb.gentoo.org/repo/gentoo.git

which is already quite explanatory in ways that a noncommittal link to
the gentoo homepage is NOT.

-- 
Eli Schwartz

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2024-05-01 14:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 13:32 [gentoo-dev] [PATCH] .github: Add pull request template Michał Górny
2024-05-01 14:27 ` Maciej Barć
2024-05-01 14:47   ` Eli Schwartz
2024-05-01 15:02     ` Maciej Barć
2024-05-01 15:15       ` Eli Schwartz
2024-05-01 15:18         ` Maciej Barć
2024-05-01 14:59   ` Michał Górny
2024-05-01 15:14     ` Maciej Barć
2024-05-01 14:28 ` Ionen Wolkens
2024-05-01 14:38   ` Maciej Barć
2024-05-01 14:54     ` Eli Schwartz [this message]
2024-05-01 15:01     ` Ulrich Mueller
2024-05-01 15:05       ` Maciej Barć
2024-05-01 15:52         ` Ulrich Mueller
2024-05-01 16:00           ` Maciej Barć
2024-05-01 15:00   ` Michał Górny
2024-05-03  4:41   ` Sam James
2024-05-03  4:41 ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c30e5ed1-d703-4332-87cf-7707560f74ab@gmail.com \
    --to=eschwartz93@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox