Re: [gentoo-dev] RFC: eutils.eclass: More reliable return status for e*_clean.

[Michael Orlitzky <mjo@gentoo.org>]

On 02/16/2018 03:46 AM, Ulrich Mueller wrote:
>
> Should we take this as an opportunity to split off these three
> functions into their own eclass, e.g. vcs-clean.eclass?

I think this is a good direction to go in. Changing a popular eclass is
always scary, and the more unrelated stuff it contains, the harder it
gets. It's not easy to tell which ebuilds use the part of the eclass
that you're touching, so you wind up testing (or at least worrying
about) them all. There's the metadata regen, too.

To make maintenance easier, I would go one step further and say that
unless two functions need the same variables or call one another, they
belong in separate eclasses. Since ecvs_clean, esvn_clean, and
egit_clean are completely independent of one another, they could go in
separate eclasses -- it's not like you'll need more than one of them in
your ebuild. Then in the future if we need to change egit_clean, we will
know precisely which ebuilds are affected.