From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 7/8] profiles/use.desc: Make USE=egl global
Date: Tue, 19 Dec 2023 12:50:59 +0100 [thread overview]
Message-ID: <c2618ffb39b8cb52dcb2b4ddaae3859738ea61ec.camel@gentoo.org> (raw)
In-Reply-To: <ce68d04788ac418f59e7a88b45eb084440a67f29.camel@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 2524 bytes --]
On Tue, 2023-12-19 at 10:33 +0200, Mart Raudsepp wrote:
> Ühel kenal päeval, P, 17.12.2023 kell 17:05, kirjutas Michał Górny:
> > Add a global USE=egl flag. It is used semi-consistently in 13
> > packages,
> > though some use it as "EGL only" flag (there is also one using
> > USE=egl-only).
> >
> > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > ---
> > dev-games/openscenegraph-openmw/metadata.xml | 1 -
> > dev-games/openscenegraph/metadata.xml | 1 -
> > dev-qt/qtgui/metadata.xml | 1 -
> > media-libs/clutter/metadata.xml | 1 -
> > media-libs/gst-plugins-bad/metadata.xml | 1 -
> > media-libs/gst-plugins-base/metadata.xml | 1 -
> > media-libs/libepoxy/metadata.xml | 3 ---
> > media-libs/libva-compat/metadata.xml | 1 -
> > media-plugins/gst-plugins-gtk/metadata.xml | 1 -
> > media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
> > profiles/use.desc | 1 +
> > 11 files changed, 1 insertion(+), 12 deletions(-)
> >
> > diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-
> > plugins/gst-plugins-gtk/metadata.xml
> > index 7235f1bab7ba..f3b18c11bcfc 100644
> > --- a/media-plugins/gst-plugins-gtk/metadata.xml
> > +++ b/media-plugins/gst-plugins-gtk/metadata.xml
> > @@ -6,7 +6,6 @@
> > <name>GStreamer package maintainers</name>
> > </maintainer>
> > <use>
> > - <flag name="egl">Enable EGL platform usage</flag>
> > <flag name="gles2">Enable gtkglsink OpenGL sink based on
> > GLESv2 API</flag>
> > <flag name="opengl">Enable gtkglsink OpenGL sink based on
> > desktop OpenGL API</flag>
> > </use>
>
> Please do not lose extra information provided in local descriptions in
> this and many other cases where you remove the local description (in
> other proposed global USE flag cases as well). Just don't remove the
> local description then. Thanks.
>
I've used my best judgment to figure out whether the local description
actually provides any "extra information". I didn't touch
the gtkglsink-related flags since they provided some information.
I fail to see how "platform usage" adds any information.
If you have "other proposed global USE flag cases" that are removing
information, please be more specific.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2023-12-19 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 16:05 [gentoo-dev] [PATCH 0/8] A batch of global USE flags Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 1/8] profiles/use.desc: Add USE=speech as a global USE flag Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 2/8] profiles/use.desc: Add USE=sid " Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 3/8] profiles/use.desc: Make USE={otf,ttf} global Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 4/8] profiles/use.desc: Make USE=opencl global Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 5/8] profiles/use.desc: Make USE=lto global Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 6/8] profiles/use.desc: Make USE=gles2 global Michał Górny
2023-12-17 16:05 ` [gentoo-dev] [PATCH 7/8] profiles/use.desc: Make USE=egl global Michał Górny
2023-12-19 8:33 ` Mart Raudsepp
2023-12-19 11:50 ` Michał Górny [this message]
2023-12-19 20:23 ` Mart Raudsepp
2023-12-17 16:05 ` [gentoo-dev] [PATCH 8/8] profiles/use.desc: Make USE=asm global Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2618ffb39b8cb52dcb2b4ddaae3859738ea61ec.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox