[gentoo-dev] Re: checkfs error

[Charlie C <phceac@yahoo.com>]

Martin Schlemmer wrote:
> On Wed, 2003-10-15 at 07:53, Jani Monoses wrote:
> ...
>> You are using an old version, or did not update your check* scripts,
>> as this was fixed in July (?) already.

That's true, but the new version is (i think) worse.
Now, it appears, return values of 1,2 or 3 do nothing, even though both 
2 and 3 should cause a reboot (unless I'm missing something).
All the rest cause a sulogin, and then ... no reboot. This seems to be 
taking a few chances with the users filesystems.

man fsck says to me that we must do a bitwise and between 2 and the 
return value to determine whether a reboot is required. i.e.:
   if  [  $((retval & 2)) != 0 ] ; then
       ewarn "fsck requires a reboot"
       rebootrequired="yes"
   fi
And common sense tells me that it would be prudent to do a reboot after 
any manual fsck-ing, when retval > 3

I've got a heavily modified version of the checkfs script(excerpt 
above). Having had some "heart-in-the-mouth" moments with the previous 
version, it's one of the things I keep an eye on...perhaps I'll have to 
submit it to bugzilla.

Charlie






--
gentoo-dev@gentoo.org mailing list