Re: [gentoo-dev] [PATCH 2/2] cargo.eclass: Preserve project-specific [build] flags by reading config

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1153 bytes --]

On Wed, 2024-08-07 at 16:52 +0100, James Le Cuirot wrote:
> The flags we set an a target-specific environment variable override any
> generic [build] flags set by the project, requiring ebuilds to set these
> themselves, which is undesirable. Work around this by using tomlq to
> read the flags from the config files checked by Cargo and prepending
> them to our environment variable.
> 
> Signed-off-by: James Le Cuirot <chewi@gentoo.org>
> ---
>  eclass/cargo.eclass | 28 +++++++++++++++++-----------
>  1 file changed, 17 insertions(+), 11 deletions(-)
> 
> diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
> index 6d4cf1b425eb..dea8c49e4585 100644
> --- a/eclass/cargo.eclass
> +++ b/eclass/cargo.eclass
> @@ -36,7 +36,8 @@ esac
>  
>  inherit flag-o-matic multiprocessing rust-toolchain toolchain-funcs
>  
> -[[ ! ${CARGO_OPTIONAL} ]] && BDEPEND="${RUST_DEPEND}"
> +# app-misc/yq is needed for tomlq.
> +[[ ! ${CARGO_OPTIONAL} ]] && BDEPEND="${RUST_DEPEND} app-misc/yq"
>  

Doesn't this imply that all ebuilds using CARGO_OPTIONAL will now have
to explicitly depend on yq?

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]