From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-89874-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 250E4138334
	for <garchives@archives.gentoo.org>; Tue, 31 Dec 2019 08:28:46 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id C9609E0E2F;
	Tue, 31 Dec 2019 08:28:41 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 78018E0E2B
	for <gentoo-dev@lists.gentoo.org>; Tue, 31 Dec 2019 08:28:41 +0000 (UTC)
Received: from thinkpad.fritz.box (p200300E2EF473200B5B0C106163C5A1F.dip0.t-ipconnect.de [IPv6:2003:e2:ef47:3200:b5b0:c106:163c:5a1f])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: soap)
	by smtp.gentoo.org (Postfix) with ESMTPSA id DDC6B34DDBF;
	Tue, 31 Dec 2019 08:28:39 +0000 (UTC)
Message-ID: <bbc3af46d736708dfb5338ffd2c573117e120438.camel@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] ruby-ng.eclass: Include (-) in
 RUBY_TARGETS USE-dependencies
From: David Seifert <soap@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= <mgorny@gentoo.org>
Date: Tue, 31 Dec 2019 09:28:36 +0100
In-Reply-To: <20191231043418.10250-1-mgorny@gentoo.org>
References: <20191231043418.10250-1-mgorny@gentoo.org>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.32.5 
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Archives-Salt: 321c6cc3-33fa-43c8-ba05-ee4902af29d0
X-Archives-Hash: b9930988d409180413b98a0ab5253188

On Tue, 2019-12-31 at 05:34 +0100, Michał Górny wrote:
> Using 2-style USE dependencies on packages not having the flag
> in question is forbidden by PMS.
> 
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  eclass/ruby-ng.eclass | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
> index db701d81f4fc..c2b9442ef489 100644
> --- a/eclass/ruby-ng.eclass
> +++ b/eclass/ruby-ng.eclass
> @@ -137,7 +137,7 @@ ruby_samelib() {
>  	local res=
>  	for _ruby_implementation in $(_ruby_get_all_impls); do
>  		has -${_ruby_implementation} $@ || \
> -			res="${res}ruby_targets_${_ruby_implementation}
> ?,"
> +			res="${res}ruby_targets_${_ruby_implementation}
> ?(-),"

https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-830008.3.4
In a 4-style use dependency, the flag name may *immediately* be
followed by a default specified by either (+) or (-)

https://github.com/gentoo-mirror/gentoo/blob/stable/metadata/md5-cache/dev-libs/boost-1.72.0
>=dev-python/numpy-1.17[python_targets_python3_6(-)?,...]

Given that you ran this through CI, this smells of dead code...

>  	done
>  
>  	echo "[${res%,}]"
> @@ -151,9 +151,9 @@ _ruby_atoms_samelib_generic() {
>  			"||" | "(" | ")" | *"?")
>  				echo "${token}" ;;
>  			*])
> -				echo
> "${token%[*}[RUBYTARGET,${token/*[}" ;;
> +				echo "${token%[*}[RUBYTARGET(-
> ),${token/*[}" ;;
>  			*)
> -				echo "${token}[RUBYTARGET]" ;;
> +				echo "${token}[RUBYTARGET(-)]" ;;
>  		esac
>  	done
>  	echo ")"