public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: James Le Cuirot <chewi@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] savedconfig.eclass: Drop support for EAPI 6
Date: Thu, 25 Jul 2024 09:02:21 +0100	[thread overview]
Message-ID: <b89505ff355f234505e516846b04f93a942d3a33.camel@gentoo.org> (raw)
In-Reply-To: <20240725053547.6281-1-ulm@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 2027 bytes --]

On Thu, 2024-07-25 at 07:35 +0200, Ulrich Müller wrote:
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
>  eclass/savedconfig.eclass | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/eclass/savedconfig.eclass b/eclass/savedconfig.eclass
> index cc5748543078..65a1f3bfd800 100644
> --- a/eclass/savedconfig.eclass
> +++ b/eclass/savedconfig.eclass
> @@ -1,10 +1,10 @@
> -# Copyright 1999-2023 Gentoo Authors
> +# Copyright 1999-2024 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # @ECLASS: savedconfig.eclass
>  # @MAINTAINER:
>  # base-system@gentoo.org
> -# @SUPPORTED_EAPIS: 6 7 8
> +# @SUPPORTED_EAPIS: 7 8
>  # @BLURB: common API for saving/restoring complex configuration files
>  # @DESCRIPTION:
>  # It is not uncommon to come across a package which has a very fine
> @@ -31,7 +31,7 @@
>  # build.
>  
>  case ${EAPI} in
> -	6|7|8) ;;
> +	7|8) ;;
>  	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
>  esac
>  
> @@ -60,12 +60,12 @@ save_config() {
>  	if [[ $# -eq 1 && -f $1 ]] ; then
>  		# Just one file, so have the ${configfile} be that config file
>  		dodir "${configfile%/*}"
> -		cp "$@" "${ED%/}/${configfile}" || die "failed to save $*"
> +		cp "$@" "${ED}/${configfile}" || die "failed to save $*"
>  	else
>  		# A dir, or multiple files, so have the ${configfile} be a dir
>  		# with all the saved stuff below it
>  		dodir "${configfile}"
> -		treecopy "$@" "${ED%/}/${configfile}" || die "failed to save $*"
> +		treecopy "$@" "${ED}/${configfile}" || die "failed to save $*"
>  	fi
>  
>  	elog "Your configuration for ${CATEGORY}/${PF} has been saved in "
> @@ -150,7 +150,7 @@ savedconfig_pkg_postinst() {
>  	# are worse :/.
>  
>  	if use savedconfig ; then
> -		find "${EROOT%/}/etc/portage/savedconfig/${CATEGORY}/${PF}" \
> +		find "${EROOT}/etc/portage/savedconfig/${CATEGORY}/${PF}" \
>  			-exec touch {} + 2>/dev/null
>  	fi
>  }

Ack.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

      reply	other threads:[~2024-07-25  8:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  5:35 [gentoo-dev] [PATCH] savedconfig.eclass: Drop support for EAPI 6 Ulrich Müller
2024-07-25  8:02 ` James Le Cuirot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b89505ff355f234505e516846b04f93a942d3a33.camel@gentoo.org \
    --to=chewi@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox