Re: [gentoo-dev] [PATCH v2 1/2] check-reqs.eclass: runtime disk checks for any path.

[zzam@gentoo.org]

Am 26.02.24 um 07:31 schrieb Robin H. Johnson:
> Allow checking any runtime path for installing ever-larger packages.
> 
> CHECKREQS_DISK_RUNTIME=( /boot:40M /:350M /opt:500M )

In the example case: Shouldn't the eclass check for 850M on / if /opt is 
not a separate partition?
I am not sure how often it really happens that multiple large 
requirements for different folders exist.

> 
> Recent example of large packages:
> 
> gentoo-kernel-bin:
> /     >=350MB/version (in /lib/modules)
> /boot >=40MB/version
> 
> rust-bin:
> /opt  >=450MB/version
> 
> Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
> ---
>   eclass/check-reqs.eclass | 23 +++++++++++++++++++++++
>   1 file changed, 23 insertions(+)
> 
> diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass
> index fac2f4553d74..1c59c69489a9 100644
> --- a/eclass/check-reqs.eclass
> +++ b/eclass/check-reqs.eclass
> @@ -30,6 +30,13 @@
>   # # install will need this much space in /var
>   # CHECKREQS_DISK_VAR="1024M"
>   #
> +# # install will need this much space in listed paths.
> +# CHECKREQS_DISK_RUNTIME=(
> +#   /var:1G
> +#   /boot/efi:32M
> +#   /opt/giant-package-with-dedicated-disk:100G
> +# )
> +#
>   # @CODE
>   #
>   # If you don't specify a value for, say, CHECKREQS_MEMORY, then the test is not
> @@ -66,6 +73,11 @@ _CHECK_REQS_ECLASS=1
>   # @DESCRIPTION:
>   # How much space is needed in /var? Eg.: CHECKREQS_DISK_VAR=3000M
>   
> +# @ECLASS_VARIABLE: CHECKREQS_DISK_RUNTIME
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# How much space is needed in paths? Eg.: CHECKREQS_DISK_RUNTIME=( /:1G /var:5G )
> +
>   # @ECLASS_VARIABLE: CHECKREQS_DONOTHING
>   # @USER_VARIABLE
>   # @DEFAULT_UNSET
> @@ -120,6 +132,7 @@ _check-reqs_prepare() {
>   	debug-print-function ${FUNCNAME} "$@"
>   
>   	if [[ -z ${CHECKREQS_MEMORY} &&
> +			"${#CHECKREQS_DISK_RUNTIME[@]}" -eq 0 &&
>   			-z ${CHECKREQS_DISK_BUILD} &&
>   			-z ${CHECKREQS_DISK_USR} &&
>   			-z ${CHECKREQS_DISK_VAR} ]]; then
> @@ -161,6 +174,16 @@ _check-reqs_run() {
>   	fi
>   
>   	if [[ ${MERGE_TYPE} != buildonly ]]; then
> +		if [[ "${#CHECKREQS_DISK_RUNTIME[@]}" -gt 0 ]]; then
> +			for _path_size in "${CHECKREQS_DISK_RUNTIME[@]}"; do
> +				_path=${_path_size/:*}
> +				_size=${_path_size/*:}
> +				_check-reqs_disk \
> +					"${EROOT%/}${_path}" "${_size}"
> +			done
> +			unset _path_size _path _size
> +		fi
> +
>   		[[ -n ${CHECKREQS_DISK_USR} ]] && \
>   			_check-reqs_disk \
>   				"${EROOT%/}/usr" \