public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Alexey Sokolov <alexey+gentoo@asokolov.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options
Date: Wed, 13 Sep 2023 08:50:32 +0100	[thread overview]
Message-ID: <b4d01bdd-54b4-278f-dba5-1db76b3e3fd3@asokolov.org> (raw)
In-Reply-To: <3b8c01be-2ac6-8594-e841-fbbff9ea1ec4@gmail.com>

13.09.2023 03:52, Eli Schwartz пишет:
> On 9/12/23 10:26 PM, Michał Górny wrote:
>> On Tue, 2023-09-12 at 22:07 -0400, Eli Schwartz wrote:
>>> On 9/12/23 3:56 PM, Ulrich Mueller wrote:
>>>>>>>>> On Tue, 12 Sep 2023, Eli Schwartz wrote:
>>>>
>>>>> +				mkdir -p "${BUILD_DIR}" || die
>>>>> +				local -x DIST_EXTRA_CONFIG="${BUILD_DIR}/extra-setup.cfg"
>>>>> +				cat > "${DIST_EXTRA_CONFIG}" <<-EOF
>>>>> +					[build]
>>>>> +					build_base = ${BUILD_DIR}/build
>>>>> +
>>>>> +					[build_ext]
>>>>> +					parallel = ${jobs}
>>>>> +				EOF
>>>>
>>>> "|| die" should also be added for the cat command.
>>>
>>>
>>> Redirecting output to a file in a directory you have just guaranteed to
>>> exist cannot fail.
>>
>> Eh, you make me prove you wrong:
>>
>> # cat > dupa <<-EOF
>> blahblah
>>> EOF
>> cat: write error: No space left on device
> 
> 
> ಠ_ಠ
> 
> Is portage generally expected to successfully complete (including
> internal metadata write stages) when its workdir drive runs out of space
> partway through?
> 
> 

This is a race with the user - the user could delete some files from 
disk just in time for metadata to successfully be written

-- 
Best regards,
Alexey "DarthGandalf" Sokolov



  parent reply	other threads:[~2023-09-13  7:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-12 19:14 [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options Eli Schwartz
2023-09-12 19:14 ` [gentoo-dev] [PATCH 2/2] python-utils-r1.eclass: unconditionally warn on occluded packages in cwd Eli Schwartz
2023-09-12 19:56 ` [gentoo-dev] [PATCH 1/2] distutils-r1.eclass: teach setuptools to respect (some) build options Ulrich Mueller
2023-09-13  2:07   ` Eli Schwartz
2023-09-13  2:26     ` Michał Górny
2023-09-13  2:52       ` Eli Schwartz
2023-09-13  3:13         ` Sam James
2023-09-13  7:50         ` Alexey Sokolov [this message]
2023-09-13 13:10         ` Michael Orlitzky
2023-09-13 21:06           ` Eli Schwartz
2023-09-13  9:27     ` Ulrich Mueller
2023-09-13 21:06       ` Eli Schwartz
2023-09-14  8:24         ` Ulrich Mueller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4d01bdd-54b4-278f-dba5-1db76b3e3fd3@asokolov.org \
    --to=alexey+gentoo@asokolov.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox