[gentoo-dev] Illegal news item name

[gentoo-dev] Illegal news item name

[Vlastimil Babka]

Hi,

it was brought up by ulm that the news item 
'2009-04-18-java-config-wrapper-0.16' has an illegal name because it 
contains a dot. As it was me who named and commited it, I am sorry for 
this mistake. The file name in -dev review mail was called 
'generation1-deprecation' and I probably should have just added the date 
to it and not try to stick to the package name + version. My bad.

The question is what to do now, rename it? Users will then see it again, 
and I don't know if there are even worse consequences.
Betelgeuse suggested also commit hook that would check filenames.

Cheers,
Vlastimil

Re: [gentoo-dev] Illegal news item name

[Zac Medico]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vlastimil Babka wrote:
> The question is what to do now, rename it? Users will then see it again,
> and I don't know if there are even worse consequences.

AFAIK, seeing it again is the worst that will happen. The cvs ->
rsync script will ensure that the incorrectly named new item is
deleted on the rsync side after it's removed from cvs.
- --
Thanks,
Zac
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)

iEYEARECAAYFAko9L60ACgkQ/ejvha5XGaMJ7QCfe/p1UHoBTrhXl4l3GXtS5YL2
zv8AoK8KiNS1feDMy6uiqKr8xReCCkP0
=1FWI
-----END PGP SIGNATURE-----

Re: [gentoo-dev] Illegal news item name

[Dale]

Zac Medico wrote:
> Vlastimil Babka wrote:
> > The question is what to do now, rename it? Users will then see it again,
> > and I don't know if there are even worse consequences.
>
> AFAIK, seeing it again is the worst that will happen. The cvs ->
> rsync script will ensure that the incorrectly named new item is
> deleted on the rsync side after it's removed from cvs.

As a lowly user, I would rather see it twice than to not see it at all. 
Although the argument could be made that java is not a critical package.

Dale

:-)  :-)

Re: [gentoo-dev] Illegal news item name

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

Dale wrote:
> Zac Medico wrote:
>> Vlastimil Babka wrote:
>>> The question is what to do now, rename it? Users will then see it again,
>>> and I don't know if there are even worse consequences.
>> AFAIK, seeing it again is the worst that will happen. The cvs ->
>> rsync script will ensure that the incorrectly named new item is
>> deleted on the rsync side after it's removed from cvs.
> 
> As a lowly user, I would rather see it twice than to not see it at all. 
> Although the argument could be made that java is not a critical package.
> 
> Dale
> 
> :-)  :-)
> 

The news items have filters so they don't show to everyone.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

Re: [gentoo-dev] Illegal news item name

[Ulrich Mueller]

>>>>> On Sat, 20 Jun 2009, Vlastimil Babka wrote:

> it was brought up by ulm that the news item 
> '2009-04-18-java-config-wrapper-0.16' has an illegal name because it 
> contains a dot.

I stumbled upon this when I experimented with news to e-mail
forwarding, where there are some limitations for the characters
allowed in headers. Of course everything can be filtered, but things
would be easier if we could stick to the GLEP 42 specification
(namely "a"-"z", "0"-"9", "+", "-", and "_").

> The question is what to do now, rename it? Users will then see it
> again, and I don't know if there are even worse consequences.

> Betelgeuse suggested also commit hook that would check filenames.

Infra, would this be possible? Only files with names
yyyy-mm-dd-shortname.lang.txt and yyyy-mm-dd-shortname.lang.txt.asc
(for detached signature) should be allowed, and character set as
mentioned above.

Ulrich

Re: [gentoo-dev] Illegal news item name

[Alec Warner]

On Sat, Jun 20, 2009 at 1:58 PM, Ulrich Mueller<ulm@gentoo.org> wrote:
>>>>>> On Sat, 20 Jun 2009, Vlastimil Babka wrote:
>
>> it was brought up by ulm that the news item
>> '2009-04-18-java-config-wrapper-0.16' has an illegal name because it
>> contains a dot.
>
> I stumbled upon this when I experimented with news to e-mail
> forwarding, where there are some limitations for the characters
> allowed in headers. Of course everything can be filtered, but things
> would be easier if we could stick to the GLEP 42 specification
> (namely "a"-"z", "0"-"9", "+", "-", and "_").
>
>> The question is what to do now, rename it? Users will then see it
>> again, and I don't know if there are even worse consequences.
>
>> Betelgeuse suggested also commit hook that would check filenames.
>
> Infra, would this be possible? Only files with names
> yyyy-mm-dd-shortname.lang.txt and yyyy-mm-dd-shortname.lang.txt.asc
> (for detached signature) should be allowed, and character set as
> mentioned above.

Write a script that checks filenames and give it to Robin (and make
sure it doesn't suck).  These types of things tend to get done faster
when you just say "here is the script to do X drop it into place plz."

>
> Ulrich
>
>

Re: [gentoo-dev] Illegal news item name

[Vlastimil Babka]

[-- Attachment #1.1: Type: text/plain, Size: 1862 bytes --]

Zac Medico wrote:
> Vlastimil Babka wrote:
>> The question is what to do now, rename it? Users will then see it again,
>> and I don't know if there are even worse consequences.
> 
> AFAIK, seeing it again is the worst that will happen. The cvs ->
> rsync script will ensure that the incorrectly named new item is
> deleted on the rsync side after it's removed from cvs.

Hi,

unfortunately this is what happens in current eselect-news.

# eselect news list
Unread news items:
  (none found)
Read news items:
  2009-04-18-java-config-wrapper-0.16
                            (no title available)
  2009-04-18-java_generation1_deprecation
                            Generation 1 Java Setup Deprecated

# eselect news read all
2009-04-18-java-config-wrapper-0.16
/usr/share/eselect/modules/news.eselect: line 92:
/usr/portage/metadata/news/2009-04-18-java-config-wrapper-0.16/2009-04-18-java-config-wrapper-0.16.en.txt:
No such file or directory

/usr/share/eselect/modules/news.eselect: line 99:
/usr/portage/metadata/news/2009-04-18-java-config-wrapper-0.16/2009-04-18-java-config-wrapper-0.16.en.txt:
No such file or directory
2009-04-18-java_generation1_deprecation
...

This is because the old entry stays in
/var/lib/gentoo/news/news-gentoo.read
Executing 'eselect news purge' will fix that, but obviously with the
side effect of purging everything else :)

So what to do? Fix eselect first and then do the rename? Rename now,
recommend purge, and fix eselect later? Update GLEP 42 to allow dots in
news item filenames? Any technical reason they are not allowed, except
for hypothetical compatibility (nothing broken was reported due to this
item yet).

(attached is the renamed version with bumped revision and note
explaining users that they might see this twice because it was renamed)

Thanks,
Vlastimil

[-- Attachment #1.2: 2009-04-18-java_generation1_deprecation.en.txt --]
[-- Type: text/plain, Size: 1231 bytes --]

Title: Generation 1 Java Setup Deprecated
Author: Petteri Räty <betelgeuse@gentoo.org>
Content-Type: text/plain
Posted: 2009-04-18
Revision: 3
News-Item-Format: 1.0
Display-If-Installed: >=dev-java/java-config-wrapper-0.16

Note: Apologies for reading this news item twice. It had to be
renamed to comply with news item specitication, which may result
in a news reader detecting a new item.

For a long time the Java team required a 1.4 JDK to be
installed in order for old java ebuilds to work. All these
ebuilds are now gone from the main tree so the requirement
to have a 1.4 JDK installed has been lifted.

In order to remove things left over by the generation 1
setup please run java-check-environment and follow the
instructions.

If you want to remove 1.4 JDKs, you should use emerge --depclean.
Depending on what you have installed you might not need a
1.4 JDK any more. To see if you still need a 1.4 JDK use:

emerge -av --depclean virtual/jdk:1.4

If you don't need virtual/jdk:1.4 any more then you can remove the
individual JDKs. First get the list of installed JDKs with
eselect and then remove those that are not needed any longer with
depclean, for example:

eselect java-vm list
emerge -av --depclean sun-jdk:1.4

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]

Re: [gentoo-dev] Illegal news item name

[Ulrich Mueller]

>>>>> On Mon, 10 Aug 2009, Vlastimil Babka wrote:

> unfortunately this is what happens in current eselect-news.
[bunch of bash error messages deleted]

Good catch. The news-tng module of eselect-1.1* handles it more
gracefully (no bash errors), but it still displays an error message.

> This is because the old entry stays in
> /var/lib/gentoo/news/news-gentoo.read

Seems that we have no real procedure for removal of news items.
Unfortunately GLEP 42 only says that they can be removed, but doesn't
specify what should happen with the entry in the news-*.unread or
news-*.read file.

Since the package manager adds these lines, I guess that it would be
its task to delete them from news-*.{unread,read} if the news item
itself was removed. Or should the eselect module handle it?

> So what to do? Fix eselect first and then do the rename? Rename now,
> recommend purge, and fix eselect later?

Seems that just keeping the item with the bad name will cause least
breakage for users. Sigh.

> Update GLEP 42 to allow dots in news item filenames?

Please don't.

> Any technical reason they are not allowed, except for hypothetical
> compatibility (nothing broken was reported due to this item yet).

The news-tng module has an option to export news items in mbox format,
and needs to generate message-ids for this. It's natural to generate
their local part from the news item's name, and then it's good to be
conservative on the allowed character set.

Ulrich