From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1Kc32A-0004GC-Eb for garchives@archives.gentoo.org; Sat, 06 Sep 2008 19:01:22 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D4D1BE0396; Sat, 6 Sep 2008 19:01:21 +0000 (UTC) Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.233]) by pigeon.gentoo.org (Postfix) with ESMTP id AD877E0396 for ; Sat, 6 Sep 2008 19:01:21 +0000 (UTC) Received: by wr-out-0506.google.com with SMTP id c37so953439wra.26 for ; Sat, 06 Sep 2008 12:01:20 -0700 (PDT) Received: by 10.70.31.4 with SMTP id e4mr16338221wxe.12.1220727680692; Sat, 06 Sep 2008 12:01:20 -0700 (PDT) Received: by 10.70.40.7 with HTTP; Sat, 6 Sep 2008 12:01:20 -0700 (PDT) Message-ID: Date: Sat, 6 Sep 2008 12:01:20 -0700 From: "Alec Warner" Sender: antarus@scriptkitty.com To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [RFC] Ability to pass arguments to src_configure/src_compile In-Reply-To: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080906173656.GB5434@spoc.mpa.com> X-Google-Sender-Auth: 3f00c9b9fc8c2cd5 X-Archives-Salt: 14cac9a9-fbad-4b72-a14a-0eb8c9807e23 X-Archives-Hash: a51624bd1d67ad4065b4728ad8cb8503 On Sat, Sep 6, 2008 at 12:00 PM, Alec Warner wrote: > On Sat, Sep 6, 2008 at 10:36 AM, Thomas Anderson wrote: >> Hi, >> Currently we have a lot of: >> src_configure() { >> econf $(use_enable dvdr) \ >> $(use_with ipv6 ssl) \ >> --with-system-zlib >> } >> >> Introducing(Idea shamelessly taken from Exherbo): >> DEFAULT_SRC_CONFIGURE_USE_{WITHS,ENABLES} >> DEFAULT_SRc_CONFIGURE_EXTRA_PARAMS >> >> The code from above could be rewritten like so: >> >> DEFAULT_SRC_CONFIGURE_USE_ENABLES=( 'dvdr' ) >> DEFAULT_SRC_CONFIGURE_USE_WITHS=( 'ipv6 ssl' ) >> DEFAULT_SRC_CONFIGURE_EXTRA_PARAMS=( '--with-system-zlib' ) >> >> That's much simpler. > > It saves you 1 line and reduces readability and intuitiveness by a > fair margin; how is it simpler? > errr s/1/2/ s/line/lines/ :/ >> >> Also taken from Exherbo, DEFAULT_SRC_COMPILE_PARAMS could be used to >> append parameters to emake like so: >> >> src_compile() { >> emake buildtarget >> } >> >> which would be replaced by: >> DEFAULT_SRC_COMPILE_PARAMS=( 'buildtarget' ) >> >> This was originally proposed in bug #230725[1] >> >> Regards, >> Thomas >> >> [1] https://bugs.gentoo.org/show_bug.cgi?id=230725 >> >