[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Christian Faulhammer]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

Hi,

"Markus Meier (maekke)" <maekke@gentoo.org>:

> DOCS="AUTHORS COPYING ChangeLog NEWS README"

 Don't install COPYING.

V-Li


-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Markus Meier]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

On Sun, 16 Mar 2008 19:00:36 +0100
Christian Faulhammer <opfer@gentoo.org> wrote:
> Hi,
> 
> "Markus Meier (maekke)" <maekke@gentoo.org>:
> 
> > DOCS="AUTHORS COPYING ChangeLog NEWS README"
> 
>  Don't install COPYING.

fixed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Rémi Cardona]

Christian Faulhammer a écrit :
>  Don't install COPYING.

Could repoman have a QA warning for COPYING inside DOCS="" and dodoc ?

Cheers,

Rémi
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Arfrever Frehtes Taifersar Arahesis]

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

2008-03-16 20:39:50 Rémi Cardona napisał(a):
> Christian Faulhammer a écrit :
> >  Don't install COPYING.
> 
> Could repoman have a QA warning for COPYING inside DOCS="" and dodoc ?

Repoman already has such QA warning in case of dodoc:

RepoMan scours the neighborhood...
  ebuild.minorsyn               1
   ${CATEGORY}/${PN}/${PF}.ebuild: Useless dodoc 'COPYING' on line: ${LINE_NUMBER}


-- 
Arfrever Frehtes Taifersar Arahesis

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Dawid Węgliński]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

Sunday, 16 of March 2008 21:10:12 Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-03-16 20:39:50 Rémi Cardona napisał(a):
> > Christian Faulhammer a écrit :
> > >  Don't install COPYING.
> >
> > Could repoman have a QA warning for COPYING inside DOCS="" and dodoc ?
>
> Repoman already has such QA warning in case of dodoc:
>
> RepoMan scours the neighborhood...
>   ebuild.minorsyn               1
>    ${CATEGORY}/${PN}/${PF}.ebuild: Useless dodoc 'COPYING' on line:
> ${LINE_NUMBER}

Not if COPYING file is inside $DOCS and is installed in the loop.

-- 
Cheers
Dawid Węgliński

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Jeroen Roovers]

On Sun, 16 Mar 2008 21:51:12 +0100
Dawid Węgliński <cla@gentoo.org> wrote:

> Not if COPYING file is inside $DOCS and is installed in the loop.

Doing something like this would work as well (and go equally unnoticed):

local DOCS="foo bar COPYING baz"
dodoc ${DOCS}

Using a loop in the ebuild would be a waste of time generally (dodoc
will do it for you). Maybe repoman should warn against mentioning the
string 'COPYING' generally? :)


Kind regards,
     JeR
--
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Mart Raudsepp]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]


On P, 2008-03-16 at 23:29 +0100, Jeroen Roovers wrote:
> On Sun, 16 Mar 2008 21:51:12 +0100
> Dawid Węgliński <cla@gentoo.org> wrote:
> 
> > Not if COPYING file is inside $DOCS and is installed in the loop.
> 
> Doing something like this would work as well (and go equally unnoticed):
> 
> local DOCS="foo bar COPYING baz"
> dodoc ${DOCS}

Well, this DOCS deal is coming through gnome2.eclass, and that's how all
of the packages using that eclass are supposed to install DOCS.
I suppose we could also add a QA warning into the eclass for COPYING?


-- 
Mart Raudsepp
Gentoo Developer
Mail: leio@gentoo.org
Weblog: http://planet.gentoo.org/developers/leio

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Dawid Węgliński]

[-- Attachment #1: Type: text/plain, Size: 831 bytes --]

Sunday, 16 of March 2008 23:58:45 Mart Raudsepp wrote:
> On P, 2008-03-16 at 23:29 +0100, Jeroen Roovers wrote:
> > On Sun, 16 Mar 2008 21:51:12 +0100
> >
> > Dawid Węgliński <cla@gentoo.org> wrote:
> > > Not if COPYING file is inside $DOCS and is installed in the loop.
> >
> > Doing something like this would work as well (and go equally unnoticed):
> >
> > local DOCS="foo bar COPYING baz"
> > dodoc ${DOCS}
>
> Well, this DOCS deal is coming through gnome2.eclass, and that's how all
> of the packages using that eclass are supposed to install DOCS.
> I suppose we could also add a QA warning into the eclass for COPYING?

Something like:

    if [[ "${DOCS/COPYING/}" != "${DOCS}" ]]; then
        ewarn "QA: Don't install COPYING file."
    fi

should be enough. ;)

-- 
Cheers
Dawid Węgliński

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

Dawid Węgliński kirjoitti:
> Sunday, 16 of March 2008 23:58:45 Mart Raudsepp wrote:
>> On P, 2008-03-16 at 23:29 +0100, Jeroen Roovers wrote:
>>> On Sun, 16 Mar 2008 21:51:12 +0100
>>>
>>> Dawid Węgliński <cla@gentoo.org> wrote:
>>>> Not if COPYING file is inside $DOCS and is installed in the loop.
>>> Doing something like this would work as well (and go equally unnoticed):
>>>
>>> local DOCS="foo bar COPYING baz"
>>> dodoc ${DOCS}
>> Well, this DOCS deal is coming through gnome2.eclass, and that's how all
>> of the packages using that eclass are supposed to install DOCS.
>> I suppose we could also add a QA warning into the eclass for COPYING?
> 
> Something like:
> 
>     if [[ "${DOCS/COPYING/}" != "${DOCS}" ]]; then
>         ewarn "QA: Don't install COPYING file."
>     fi
> 
> should be enough. ;)
> 

${DOCS} = *COPYING*

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/inkscape: ChangeLog inkscape-0.46-r1.ebuild

[Alec Warner]

On 3/16/08, Jeroen Roovers <jer@gentoo.org> wrote:
> On Sun, 16 Mar 2008 21:51:12 +0100
>  Dawid Węgliński <cla@gentoo.org> wrote:
>
>  > Not if COPYING file is inside $DOCS and is installed in the loop.
>
>
> Doing something like this would work as well (and go equally unnoticed):
>
>  local DOCS="foo bar COPYING baz"
>  dodoc ${DOCS}
>
>  Using a loop in the ebuild would be a waste of time generally (dodoc
>  will do it for you). Maybe repoman should warn against mentioning the
>  string 'COPYING' generally? :)

And maybe repoman should do your laundry and dishes too? ;P

But seriously, the bash parsing in repoman is already shitty as hell.
Maybe someone should write a qa mode for ebuild.sh that enables all of
this crap so that we don't have to do horrible regex hacks that have
all kinds of edge cases ;)

That being said dev-portage typically accepts repoman patches, but I
know no one will submit any ;)

-Alec

>
>
>  Kind regards,
>      JeR
>
> --
>  gentoo-dev@lists.gentoo.org mailing list
>
>
éí˘‡^žXŹśČ\x1ežÚ(˘¸&j)bž	b˛