From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from <gentoo-dev+bounces-27224-garchives=archives.gentoo.org@gentoo.org>) id 1IiMmr-0007hv-V0 for garchives@archives.gentoo.org; Thu, 18 Oct 2007 04:15:10 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9I43tXg014310; Thu, 18 Oct 2007 04:03:55 GMT Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9I41lGR011404 for <gentoo-dev@lists.gentoo.org>; Thu, 18 Oct 2007 04:01:47 GMT Received: by nf-out-0910.google.com with SMTP id f5so36917nfh for <gentoo-dev@lists.gentoo.org>; Wed, 17 Oct 2007 21:01:47 -0700 (PDT) Received: by 10.78.134.2 with SMTP id h2mr18252hud.1192680106321; Wed, 17 Oct 2007 21:01:46 -0700 (PDT) Received: by 10.78.52.6 with HTTP; Wed, 17 Oct 2007 21:01:46 -0700 (PDT) Message-ID: <b41005390710172101v4da2b2b0n3e26a4da733edc42@mail.gmail.com> Date: Wed, 17 Oct 2007 21:01:46 -0700 From: "Alec Warner" <antarus@gentoo.org> Sender: antarus@scriptkitty.com To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/sandbox: ChangeLog sandbox-1.2.18.1-r1.ebuild In-Reply-To: <4716CED8.6050202@gentoo.org> Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <E1IiBEq-0003K6-Vv@stork.gentoo.org> <20071018005129.GE5699@supernova> <4716CED8.6050202@gentoo.org> X-Google-Sender-Auth: 2ed461063fec52cc X-Archives-Salt: 366f9aac-47b8-4542-8553-ca1c7c6f61d8 X-Archives-Hash: 4fd0b27c8f9545d028106d6db9fb5176 On 10/17/07, Doug Goldstein <cardoe@gentoo.org> wrote: > Donnie Berkholz wrote: > > On 15:55 Wed 17 Oct , Daniel Drake (dsd) wrote: > >> 1.1 sys-apps/sandbox/sandbox-1.2.18.1-r1.ebuild > >> > >> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/sandbox/sandbox-1.2.18.1-r1.ebuild?rev=1.1&view=markup > >> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-apps/sandbox/sandbox-1.2.18.1-r1.ebuild?rev=1.1&content-type=text/plain > > > >> keepdir /var/log/sandbox > >> fowners root:portage /var/log/sandbox > >> fperms 0770 /var/log/sandbox > >> > >> cd ${S} > >> dodoc AUTHORS ChangeLog NEWS README > >> } > >> > >> pkg_preinst() { > >> chown root:portage ${D}/var/log/sandbox > >> chmod 0770 ${D}/var/log/sandbox > >> } > > > > How come you need to repeat the permissions like this? > > > > Also, quoting. =) > > > > Thanks, > > Donnie > > Also, pkg_preinst() is not binary package safe. So unless the portage > group is always the same gid on EVERY Gentoo box. This will break binary > packages. Eh? pkg_* runs for binpkgs...so depending on the target machine it will chown appropriately in $IMAGE and then merge to the livefs. If you build the binpkg on machine A and install it on B, pkg_preinst will run on both (once for the build and one for the install) -Alec -- gentoo-dev@gentoo.org mailing list