From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1IhVb1-00032c-Pp for garchives@archives.gentoo.org; Mon, 15 Oct 2007 19:27:24 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.1/8.14.0) with SMTP id l9FJGHnk004941; Mon, 15 Oct 2007 19:16:17 GMT Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.184]) by robin.gentoo.org (8.14.1/8.14.0) with ESMTP id l9FJEPf3002640 for ; Mon, 15 Oct 2007 19:14:25 GMT Received: by nf-out-0910.google.com with SMTP id f5so1476355nfh for ; Mon, 15 Oct 2007 12:14:25 -0700 (PDT) Received: by 10.78.201.15 with SMTP id y15mr4231653huf.1192475664023; Mon, 15 Oct 2007 12:14:24 -0700 (PDT) Received: by 10.78.52.6 with HTTP; Mon, 15 Oct 2007 12:14:23 -0700 (PDT) Message-ID: Date: Mon, 15 Oct 2007 12:14:23 -0700 From: "Alec Warner" Sender: antarus@scriptkitty.com To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-tv/mythtv: ChangeLog mythtv-0.20.2_p14668.ebuild mythtv-0.21_pre14666.ebuild mythtv-0.21_pre14480-r1.ebuild In-Reply-To: <47137B11.1070003@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20071013004453.GM23990@supernova> <4711974B.6010505@gentoo.org> <20071014045010.GS23990@supernova> <47137651.8040503@gentoo.org> <47137849.7030608@utas.edu.au> <47137B11.1070003@gentoo.org> X-Google-Sender-Auth: 6fd4f4a426dc640f X-Archives-Salt: d63dc15a-3096-4a86-9d82-ccdd842f326d X-Archives-Hash: d40a56166b38a5d28a60856f3a600f1e On 10/15/07, Doug Goldstein wrote: > Jonathan Adamczewski wrote: > > Doug Goldstein wrote: > > > >> That's what this commits review list feels like. > >> > >> > > > > > > Nearly every suggestion (from Donnie and others) has been over some > > issue that relates directly to either correctness or maintainability. > > It doesn't matter if you can "rattle off capabilities to a millimeter" - > > if they're not documented somewhere (like, say, in the comments of the > > ebuild) then the maintainer that comes after you gets to go and break it > > all over again. > > > > > > jonathan. > > > Correctness? Fine. Go ahead. Stick $(use_enable xvmc) into the ebuild. > Do it. I dare you. Then try to compile. > > Guess what? When it blows up... that's called INcorrect. The opposite of > the right thing. > > The maintainer who comes after me would be someone with a experience > with the package. Some bumkin isn't going to come to maintain package > XYZ unless they know or use the package, and guess what? That means > experience. I think this assumption is false. People maintain packages they don't know the intricate details of all the time. You are of course, free to ignore any and all suggestions offered; but you are not allowed to silence them. -Alec -- gentoo-dev@gentoo.org mailing list