[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-java/rjava: rjava-0.5.1.ebuild metadata.xml Manifest ChangeLog

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-java/rjava: rjava-0.5.1.ebuild metadata.xml Manifest ChangeLog

[Donnie Berkholz]

On 04:42 Mon 01 Oct     , Steve Arnold (nerdboy) wrote:
> Revision  Changes    Path
> 1.1                  dev-java/rjava/rjava-0.5.1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	export R_HOME="/usr/$(get_libdir)/R"
> 
> 	# use R's check command to test package (really needs to come before
> 	# the src_compile section)
> 	if has test ${FEATURES}; then
> 	    cd ${WORKDIR}
> 	    R CMD check ${MY_PN}
> 	fi

WORKDIR needs quotes.. Also this section is pretty weird.

> 	make -f Makevars all || die "make failed"

Not emake?

> 	cd ${WORKDIR}
> 	cd ${S}

Quotes..

> 	if [[ ! -z "`java-config --java-version | grep IBM`" ]] ; then

-n might be a bit clearer than ! -z.

> 		# IBM JDK
> 		JAVA_LIB_DIR="$(java-config --jdk-home)/jre/bin"
> 	else
> 		# Sun derived JDKs (Blackdown, Sun)
> 		JAVA_LIB_DIR="$(java-config --jdk-home)/jre/lib/${jvmarch}"
> 	fi

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-java/rjava: rjava-0.5.1.ebuild metadata.xml Manifest ChangeLog

[Ed Catmur]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

Donnie Berkholz wrote:
> On 04:42 Mon 01 Oct     , Steve Arnold (nerdboy) wrote:
>> Revision  Changes    Path
>> 1.1                  dev-java/rjava/rjava-0.5.1.ebuild 
>> 
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&content-type=text/plain
>  
> 
>> 	if [[ ! -z "`java-config --java-version | grep IBM`" ]] ; then
> 
> -n might be a bit clearer than ! -z. 
> 

UUOC much?  Surely:
    if java-config --java-version | grep -q IBM ; then 

Ed

[-- Attachment #2: Type: text/html, Size: 1307 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-java/rjava: rjava-0.5.1.ebuild metadata.xml Manifest ChangeLog

[Alec Warner]

On 9/30/07, Donnie Berkholz <dberkholz@gentoo.org> wrote:
> On 04:42 Mon 01 Oct     , Steve Arnold (nerdboy) wrote:
> > Revision  Changes    Path
> > 1.1                  dev-java/rjava/rjava-0.5.1.ebuild
> >
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&content-type=text/plain
>
> > src_compile() {
> >       export R_HOME="/usr/$(get_libdir)/R"
> >
> >       # use R's check command to test package (really needs to come before
> >       # the src_compile section)
> >       if has test ${FEATURES}; then
> >           cd ${WORKDIR}
> >           R CMD check ${MY_PN}
> >       fi

Wouldn't you over-ride src_test in this case?

It would be interesting if you could specify the testing command
rather than doing a hack like this.

TEST_CMD='/path/to/R CMD check ${MY_PN}'

then in src_test in ebuild.sh we would use that var if make failed or
something similar.
-- 
gentoo-dev@gentoo.org mailing list