Re: [gentoo-dev] Reviewing ebuilds with git

[Jaco Kroon <jaco@uls.co.za>]

Hi,

Is there a way to make this work with github PR reviews?

Kind regards,
Jaco

On 2024/06/30 19:38, Sam James wrote:

> Hi,
>
> I've mentioned this on IRC a bunch of times to people but I figure I'll
> mention it here in case anyone finds it useful.
>
> Our use of git doesn't lend itself well to the default mode `git diff`
> and friends operate in, as we create many new files rather than solely
> changing existing ones.
>
> git can be coerced into checking for copies (and doing so "harder" too)
> but there's no configuration option for this, and it's a pain to
> remember.
>
> You can use the attached patch for dev-vcs/git and then set:
> $ git config diff.renames copies-harder
> in gentoo.git to make `git log -p`, `git diff`, etc default to this
> mode.
>
> IME, it makes reviewing much easier. Be warned that it does make git log
> a bit slower though if the config option is enabled for a repo -- but
> maybe only noticeably if your repo is grafted with the pre-2015 CVS history.
>
>
> thanks,
> sam
>