From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9D14A15800A for ; Fri, 14 Jul 2023 16:16:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7F648E08BD; Fri, 14 Jul 2023 16:16:49 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 31322E0845 for ; Fri, 14 Jul 2023 16:16:49 +0000 (UTC) Message-ID: Subject: Re: [gentoo-dev] Re: [PATCH] ruby-utils.eclass: Simplify _ruby_implementation_depend From: Hans de Graaff To: gentoo-dev@lists.gentoo.org Date: Fri, 14 Jul 2023 18:16:39 +0200 In-Reply-To: <877cr228h9.fsf@gentoo.org> References: <20230714083427.467176-1-sam@gentoo.org> <877cr228h9.fsf@gentoo.org> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-qU3k5+0Oy5LYjTgrcHYo" User-Agent: Evolution 3.48.3 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: bc72e208-7cdf-49f9-8f7d-f3885152efdb X-Archives-Hash: 566a0ab5c7ce01bd618772f2f732f34c --=-qU3k5+0Oy5LYjTgrcHYo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 1970-01-01 at 00:00 +0000, Sam James wrote: >=20 > Sam James writes: >=20 > > From: konsolebox > >=20 > > Closes: https://bugs.gentoo.org/909529 > > Signed-off-by: Sam James >=20 > ftr, while I find the case really repetitive, I'm not sure if this > crosses the line into unreadable bash or not, so I feel on the fence. I don't have a strong preference either way. We only need to change this once a year anyway. Perhaps not having the large case statement makes the whole file a bit more readable at the expense of a more difficult expression. Hans --=-qU3k5+0Oy5LYjTgrcHYo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEIggVRmJzp0YePtgn2zR/k4ZU+jQFAmSxdOcACgkQ2zR/k4ZU +jSwmggAn5FcahnuB1nhjVWCbQtH3WMa/lyXhDJOEWuIGifibBi04xjinf3cVQq7 PbPVyKENNXRgPDgHYHjNc3rYtiUFxXzYEQxY5iCM5jLKeOmnqhYEH6sHYMokVC73 JAPLhbMBd4KIRq5BhlEW/d6jr/2Gey5CtRBPaOVEXE+93SGcCmfyoABM5PO/6Rc+ ttQ00kIl4AZKVul+uovfLdDEUpRvO5sn5PQ/6xbLIRkmFvPUD1KgzlcT0h+keJ8f dEbRxdrT9dC1LpnSlvzWarbnpedYv1VP2h7ESX7op9c7SlAY6lD3FIeuTm3+0v74 fzOhtvMpeswAs/ilnvOv6e35XJKSJw== =aSnr -----END PGP SIGNATURE----- --=-qU3k5+0Oy5LYjTgrcHYo--