From: Hans de Graaff <graaff@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH] ruby-utils.eclass: Simplify _ruby_implementation_depend
Date: Fri, 14 Jul 2023 18:16:39 +0200 [thread overview]
Message-ID: <b034cfbeb51184171a42a4223e3bad7f00d0a1ac.camel@gentoo.org> (raw)
In-Reply-To: <877cr228h9.fsf@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 629 bytes --]
On Thu, 1970-01-01 at 00:00 +0000, Sam James wrote:
>
> Sam James <sam@gentoo.org> writes:
>
> > From: konsolebox <konsolebox@gmail.com>
> >
> > Closes: https://bugs.gentoo.org/909529
> > Signed-off-by: Sam James <sam@gentoo.org>
>
> ftr, while I find the case really repetitive, I'm not sure if this
> crosses the line into unreadable bash or not, so I feel on the fence.
I don't have a strong preference either way. We only need to change
this once a year anyway.
Perhaps not having the large case statement makes the whole file a bit
more readable at the expense of a more difficult expression.
Hans
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-07-14 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:34 [gentoo-dev] [PATCH] ruby-utils.eclass: Simplify _ruby_implementation_depend Sam James
2023-07-14 8:37 ` [gentoo-dev] " Sam James
2023-07-14 16:16 ` Hans de Graaff [this message]
2023-07-14 16:19 ` Arthur Zamarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b034cfbeb51184171a42a4223e3bad7f00d0a1ac.camel@gentoo.org \
--to=graaff@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox