public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "William L. Thomson Jr." <wlt-ml@o-sinc.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [patch] golang-vcs-snapshot.eclass: add vendoring of external dependencies
Date: Thu, 09 Mar 2017 14:00:08 -0500	[thread overview]
Message-ID: <assp.0241e73dd9.3132974.yaoWBZezWU@wlt> (raw)
In-Reply-To: <120bbcb6-3b6b-8258-336f-5ef6eca565af@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

On Thursday, March 9, 2017 1:29:55 PM EST Michael Orlitzky wrote:
> On 03/09/2017 01:21 PM, William L. Thomson Jr. wrote:
> > Pretty sure no need for the ||die, rm -fr should never fail.
> > 
> > rm -fr "${VENDOR_PATH}/${VENDORPN}" || die
> 
> $ rm -rf /bin/cp || echo "it failed"
> rm: cannot remove '/bin/cp': Permission denied
> it failed

Under what circumstances?

It is possible, but not to likely, as the dirs are part of a package unpacked. 
User would have permissions. If portage is not being run as root. If run as 
root, only extended file attributions ( immutable ) can prevent root from 
removing. Not likely set in a packaged unpacked.

This part of the eclass is handling sources from VC. I am not sure how they 
can be pulled in with permissions that would prevent what ever user portage is 
running under from removing a directory.

Seems like it is not possible to generate the above permission issue.

-- 
William L. Thomson Jr.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2017-03-09 19:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-09 17:58 [gentoo-dev] [patch] golang-vcs-snapshot.eclass: add vendoring of external dependencies William Hubbs
2017-03-09 18:21 ` William L. Thomson Jr.
2017-03-09 18:29   ` Michael Orlitzky
2017-03-09 19:00     ` William L. Thomson Jr. [this message]
2017-03-09 19:28       ` Michael Orlitzky
2017-03-09 23:16         ` William L. Thomson Jr.
2017-03-10  0:08           ` Michael Orlitzky
2017-03-10  0:43             ` William L. Thomson Jr.
2017-03-10  1:03               ` William L. Thomson Jr.
2017-03-10  7:38                 ` Ulrich Mueller
2017-03-12  2:00           ` Kent Fredric
2017-03-13 14:06 ` William Hubbs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=assp.0241e73dd9.3132974.yaoWBZezWU@wlt \
    --to=wlt-ml@o-sinc.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox