From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6E802158086 for ; Tue, 4 Jan 2022 23:31:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D0BCD2BC074; Tue, 4 Jan 2022 23:31:26 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3BFD92BC004 for ; Tue, 4 Jan 2022 23:31:26 +0000 (UTC) Message-ID: Date: Tue, 4 Jan 2022 18:31:22 -0500 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [gentoo-dev] [PATCH v3] kernel-2.eclass: Respect portage toolchain variables Content-Language: en-US To: gentoo-dev@lists.gentoo.org References: <20220103174926.2194473-1-adrian.ratiu@collabora.com> <4CC4B716-65A7-44C0-B7F0-D3C4E5E42C2F@gentoo.org> From: Mike In-Reply-To: <4CC4B716-65A7-44C0-B7F0-D3C4E5E42C2F@gentoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Archives-Salt: b8f327f6-55bc-4d62-af5f-1fd94142996e X-Archives-Hash: 7a524a1d34c3ea79d9b24cf5be12de96 On 1/4/22 18:25, Sam James wrote: > > >> On 3 Jan 2022, at 18:23, Mike Gilbert > > wrote: On Mon, Jan 3, 2022 at 12:49 >> PM Adrian Ratiu > > wrote: >>> >>> Starting with kernel>=v5.7 the build system can override the >>> tools vars by setting LLVM=1 [1], but older kernels still use >>> the default GNU tools, so to be able to use a full LLVM/Clang >>> build, CC & co should be set to their respective portage values. >>> >>> [1] a0d1c951ef08 kbuild: support LLVM=1 to switch the default >>> tools to Clang/LLVM >>> >>> Co-authored-by: Manoj Gupta >> > Signed-off-by: Adrian Ratiu >>> > >>> [snip] >> >> This seems ok to me, at least given the way the eclass currently >> works. >> >> At some point, we should really convert xmakeopts into an array. >> Any of these variables might contain spaces, and that would break >> the current implementation. > > agreed, but lgtm Thanks to both authors for your work, this has been committed. -- Mike Pagano Gentoo Developer - Kernel Project Gentoo Sources - Lead E-Mail : mpagano@gentoo.org GnuPG FP : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137 Public Key : http://http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index