From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id EAA0F158089 for ; Thu, 5 Oct 2023 19:19:36 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BF3A02BC05E; Thu, 5 Oct 2023 19:19:33 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7C9602BC01A for ; Thu, 5 Oct 2023 19:19:33 +0000 (UTC) Message-ID: Date: Thu, 5 Oct 2023 22:19:11 +0300 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [gentoo-dev] Re: [DRAFT] GLEP 84: Standard format for package.mask files Content-Language: en-US To: gentoo-dev@lists.gentoo.org Cc: glep@gentoo.org References: From: Arthur Zamarin In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------BS6sT70sqF767ALU4D6WWQjP" X-Archives-Salt: e522ce84-cbd9-4ac9-ae8a-66e01a6bb59e X-Archives-Hash: 4f585c8d7b99d900e7267350faf31f9b This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------BS6sT70sqF767ALU4D6WWQjP Content-Type: multipart/mixed; boundary="------------UGBnxCxHO1Ns3aCPWTZjk67R"; protected-headers="v1" From: Arthur Zamarin To: gentoo-dev@lists.gentoo.org Cc: glep@gentoo.org Message-ID: Subject: Re: [gentoo-dev] Re: [DRAFT] GLEP 84: Standard format for package.mask files References: In-Reply-To: --------------UGBnxCxHO1Ns3aCPWTZjk67R Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/10/2023 21.40, Ulrich Mueller wrote: >>>>>> On Wed, 04 Oct 2023, Arthur Zamarin wrote: >=20 >> Files can decide to add some extra file documentation, in which case, = the >> entries start after the line: >=20 >> #--- END OF EXAMPLES --- >=20 > This agrees with current package.mask, but seems rather specific. > Instead of reinventing the wheel, maybe a "scissors line" could be used= , > i.e. a line consisting mainly of "-", ">8" and "8<", similar to the lin= e > used by git-mailinfo? >=20 > I'm also wondering if we shouldn't have a similar marker for the end of= > the mask entries, i.e. everything after it would be ignored. This isn't= > currently needed for package.mask, but other files in profiles have an > Emacs local variables block or a Vim modeline at the end. >=20 > Ulrich After fast discussion on #gentoo-dev IRC between me and ulm, we agreed that the "scissors line" from git-mailinfo would be very overkill and also very complicated to implement. So we agreed on something simpler and good enough. Comment line containing at least 5 "-" on beginning and end. As regex: # -{5,}.*-{5,} All lines before first occurrence of such line (except the GLEP header to opt in) are ignored as generic comments not part of mask, and all lines after second occurrence (if exists) are also ignored. Those lines are optional, which does mean that implementation should firstly filter out the ignored part (before first time if found, and after second time if found), and only that part parse. This means implementing it as a straight stream is much-much harder, but since the file are never very big, I think it won't impact performance to perform multiple text runs. --=20 Arthur Zamarin arthurzam@gentoo.org Gentoo Linux developer (Python, pkgcore stack, Arch Teams, GURU) --------------UGBnxCxHO1Ns3aCPWTZjk67R-- --------------BS6sT70sqF767ALU4D6WWQjP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEE/axFlFuH2ptjtO5EAqCvUD0SBQQFAmUfDC8ACgkQAqCvUD0S BQTz0Af9FgS2JEEHz5Pv+WT8XVLyKXnF1Q7n2yeWeLKU4AAB0yn0EXl3EbCtNjpm 12SPTEbQxvYD5xPDmaH5cf1O+5Vl8Xt3ydzniSUBSar5p0hShk46t5jAhJ+xVkzP ByP0pO1gWPABnVeoxh7RHyU6G96IhK4HgEi7fDlz8bDDtBkpCK7VFElHirPJlslR loM6lh0Nc0jYQB02vC0iXQ2M5RVXfSnYtS4C8cTit4rh/SJqSjulk92lbGjI6UAp AFlUzSWrT5Hs8alI9FJzHmU/hvbPhg0kuWLJAVppbMEeCr6M1xw4ZdVpiIjyj5LD 6q4bfXw0vVTW3fwMNZy891Ecr+CBCg== =BSyR -----END PGP SIGNATURE----- --------------BS6sT70sqF767ALU4D6WWQjP--