From: Jaco Kroon <jaco@uls.co.za>
To: gentoo-dev@lists.gentoo.org, Mike Gilbert <floppym@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst
Date: Fri, 16 Aug 2019 11:24:49 +0200 [thread overview]
Message-ID: <a4d27cb4-e8d4-0c22-3c05-13ef26225810@uls.co.za> (raw)
In-Reply-To: <CAJ0EP43DSEkD1=BpE6zvEQK-=Kp44J3xAmAw15mBnE0CgLiUuQ@mail.gmail.com>
Hi,
On 2019/08/15 16:47, Mike Gilbert wrote:
> On Thu, Aug 15, 2019 at 8:33 AM Michael Orlitzky <mjo@gentoo.org> wrote:
>> On 8/15/19 3:19 AM, Ulrich Mueller wrote:
>>> I don't think that's a sane situation, so maybe the eclass should just
>>> die here? (Basically, there are two possibilities: Either, things will
>>> break if the dir is missing, then dying might be the best option.
>>> Or, everything works without the dir, then the ebuild should set it to
>>> /dev/null, in the first place.)
>>>
>> That's my feeling as well. In 100% of cases so far, this has been a
>> useful QA tool. Can we wait until that's not the case to change it?
> I think an explicit die with a useful error message for the user would
> be better than the status-quo.
I agree.
Kind Regards,
Jaco
prev parent reply other threads:[~2019-08-16 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 23:54 [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst Mike Gilbert
2019-08-15 6:04 ` Michał Górny
2019-08-15 7:19 ` Ulrich Mueller
2019-08-15 12:33 ` Michael Orlitzky
2019-08-15 14:47 ` Mike Gilbert
2019-08-16 9:24 ` Jaco Kroon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a4d27cb4-e8d4-0c22-3c05-13ef26225810@uls.co.za \
--to=jaco@uls.co.za \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox