From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: python@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Introduce install_for_testing --via-root
Date: Sun, 29 Nov 2020 12:48:46 +0100 [thread overview]
Message-ID: <a3b16a47777bb78fd1a76e4fc3c38a73373050af.camel@gentoo.org> (raw)
In-Reply-To: <uim9oxw7h@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Sun, 2020-11-29 at 12:02 +0100, Ulrich Mueller wrote:
> > > > > > On Sun, 29 Nov 2020, Michał Górny wrote:
>
> > + case ${install_method} in
> > + home)
> > + local add_args=(
> > + install
> > + --home="${TEST_DIR}"
> > + --install-lib="${libdir}"
> > + --install-scripts="${bindir}"
> > + )
> > + mkdir -p "${libdir}" || die
> > + ;;
> > + root)
> > + local add_args=(
> > + install
> > + --root="${TEST_DIR}"
> > + --install-lib=lib
> > + --install-scripts=scripts
> > + )
> > + ;;
> > + esac
>
> Having the same "local add_args" declaration twice looks strange and may
> be error prone. Can you move it outside of the case statement?
>
> Also, why are the array elements at different indent levels?
>
Because they are options passed to 'install' command.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
prev parent reply other threads:[~2020-11-29 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 23:51 [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Introduce install_for_testing --via-root Michał Górny
2020-11-28 23:51 ` [gentoo-dev] [PATCH 2/4] dev-python/hypothesis: Use dift --via-root API Michał Górny
2020-11-28 23:51 ` [gentoo-dev] [PATCH 3/4] distutils-r1.eclass: Accept distutils_enable_tests --install Michał Górny
2020-11-29 11:03 ` Ulrich Mueller
2020-11-28 23:51 ` [gentoo-dev] [PATCH 4/4] dev-python/flake8: Use " Michał Górny
2020-11-29 11:02 ` [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Introduce install_for_testing --via-root Ulrich Mueller
2020-11-29 11:48 ` Michał Górny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3b16a47777bb78fd1a76e4fc3c38a73373050af.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=python@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox