From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C7875138334 for ; Wed, 6 Nov 2019 07:15:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 800A4E0A10; Wed, 6 Nov 2019 07:15:21 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 26B13E09DB for ; Wed, 6 Nov 2019 07:15:21 +0000 (UTC) Received: from pomiot (c134-66.icpnet.pl [85.221.134.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 8474A34C827; Wed, 6 Nov 2019 07:15:18 +0000 (UTC) Message-ID: Subject: Re: [gentoo-dev] [PATCH 1/3] ecm-utils.eclass: New eclass From: =?UTF-8?Q?Micha=C5=82_G=C3=B3rny?= To: gentoo-dev@lists.gentoo.org Date: Wed, 06 Nov 2019 08:15:13 +0100 In-Reply-To: <4949294.KT39OxLedd@tuxbrain> References: <9898161.uzqcMZjEFU@tuxk10> <2344877.D1iEJ5bPx9@tuxbrain> <759405ee4e4ae48d65cbac336e23f91ceec53ea1.camel@gentoo.org> <4949294.KT39OxLedd@tuxbrain> Organization: Gentoo Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-T+THlekAZwX76gAyPv6n" User-Agent: Evolution 3.32.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: d89b0108-e94e-4068-940e-99aaf1e9de4f X-Archives-Hash: 9caf74e0d4df3c185d3b10e3ed7352a2 --=-T+THlekAZwX76gAyPv6n Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-11-06 at 02:19 +0100, Andreas Sturmlechner wrote: > > > +# @ECLASS-VARIABLE: ECM_NONGUI > > > +# @DESCRIPTION: > > > +# If set to "false", add dependency on kde-frameworks/breeze-icons > > > +# or kde-frameworks/oxygen-icons and run the xdg.eclass routines for > > > +# pkg_preinst, pkg_postinst and pkg_postrm. > > > +# For any other value, do nothing. > > > +if [[ ${CATEGORY} =3D kde-frameworks ]]; then > > > + : ${ECM_NONGUI:=3Dtrue} > > > +fi > > > +: ${ECM_NONGUI:=3Dfalse} > >=20 > > I don't think eclassdoc is going to parse this correctly. >=20 > Can we do something about that? I need to be able to set (overrideable)= =20 > defaults for a category without being limited by eclassdoc. @DEFAULT_UNSE= T=20 > would not be precise. Same as ECM_QTHELP, this is what we do in kde5.ecla= ss=20 > already. >=20 If I knew, I would've told you. I've personally settled for @DEFAULT_UNSET, and explained what happens when it's unset.=20 Alternatively, you could set default earlier in a separate var, then do something like: : ${ECM_NONGUI:=3D${ECM_NONGUI_DEFAULT}} but I don't think that will be very helpful. Maybe sth like: : ${ECM_NONGUI:=3D${IS_KDE_FRAMEWORKS}} but then, it's just a hack. --=20 Best regards, Micha=C5=82 G=C3=B3rny --=-T+THlekAZwX76gAyPv6n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEx2qEUJQJjSjMiybFY5ra4jKeJA4FAl3CcwJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEM3 NkE4NDUwOTQwOThEMjhDQzhCMjZDNTYzOUFEQUUyMzI5RTI0MEUACgkQY5ra4jKe JA6vlwgAxxUGdfleaFQLmJcZis0XmbaVN551bwfLaCEIfr2oeUoMGkivOj65WasE qztrOxsHJz8MyjZSxd/Kgm8I88rFzHnLQ8TpqcEEKjtcLLbm+UgTohksXjGXP4SZ OBAk6Al2x3UzF4UkJLy4UHPOoMeg9aevQfGipYVpYh3dAq/C7Iks4+Jawe/Equ8c nnAWQHYvB8FtjT5AZ1jopsIZhq8sGBkyXz14XlKj103gwwK4sqptuhPR61UpI2xD ApPC1IUvD0O0XvltJKFMpL9fl7hiqfJPAxIYSJxsR3xOLOtZycYTG+6tJmpZg82d Fmhd1yPjuiSWOfiM/W0DLtMlLyQ8MA== =nsAv -----END PGP SIGNATURE----- --=-T+THlekAZwX76gAyPv6n--