Re: [gentoo-dev] [PATCH 1/3] ecm-utils.eclass: New eclass

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

On Wed, 2019-11-06 at 02:19 +0100, Andreas Sturmlechner wrote:
> > > +# @ECLASS-VARIABLE: ECM_NONGUI
> > > +# @DESCRIPTION:
> > > +# If set to "false", add dependency on kde-frameworks/breeze-icons
> > > +# or kde-frameworks/oxygen-icons and run the xdg.eclass routines for
> > > +# pkg_preinst, pkg_postinst and pkg_postrm.
> > > +# For any other value, do nothing.
> > > +if [[ ${CATEGORY} = kde-frameworks ]]; then
> > > +	: ${ECM_NONGUI:=true}
> > > +fi
> > > +: ${ECM_NONGUI:=false}
> > 
> > I don't think eclassdoc is going to parse this correctly.
> 
> Can we do something about that? I need to be able to set (overrideable) 
> defaults for a category without being limited by eclassdoc. @DEFAULT_UNSET 
> would not be precise. Same as ECM_QTHELP, this is what we do in kde5.eclass 
> already.
> 

If I knew, I would've told you.  I've personally settled for
@DEFAULT_UNSET, and explained what happens when it's unset. 
Alternatively, you could set default earlier in a separate var, then do
something like:

: ${ECM_NONGUI:=${ECM_NONGUI_DEFAULT}}

but I don't think that will be very helpful.  Maybe sth like:

: ${ECM_NONGUI:=${IS_KDE_FRAMEWORKS}}

but then, it's just a hack.

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]