[gentoo-dev] questions about wxwidgets.eclass

[gentoo-dev] questions about wxwidgets.eclass

[Andrey Grozin]

Hello *,

1. From which phase function should setup-wxwidgets be called?
The current statistics of the packages in the tree is:
src_configure 66
src_prepare   16
pkg_setup      6
pkg_prepare    1
Does this mean that one of these groups is right, and the other 3 ones are 
wrong and should be fixed?

2. Suppose a user has 2 slots installed, 3.0-gtk3 and 3.2-gtk3. [S]he can 
eselect one of them. The slot used during emerging a package should depend 
only on WX_GTK_VER in the ebuild, and must not depend on which slot is 
currently eselected. Does wxwidgets.eclass guarantee this?

Andrey

Re: [gentoo-dev] questions about wxwidgets.eclass

[Eli Schwartz]

[-- Attachment #1.1.1: Type: text/plain, Size: 1417 bytes --]

On 7/3/24 12:19 AM, Andrey Grozin wrote:
> Hello *,
> 
> 1. From which phase function should setup-wxwidgets be called?
> The current statistics of the packages in the tree is:
> src_configure 66
> src_prepare   16
> pkg_setup      6
> pkg_prepare    1
> Does this mean that one of these groups is right, and the other 3 ones
> are wrong and should be fixed?


Well, the eclass docs *literally* state the answer:

https://devmanual.gentoo.org/eclass-reference/wxwidgets.eclass/

"""
Call this in your ebuild to set up the environment for wxGTK in
src_configure.
"""

So I would imagine that packages calling it elsewhere should switch to
doing it in src_configure...


> 2. Suppose a user has 2 slots installed, 3.0-gtk3 and 3.2-gtk3. [S]he
> can eselect one of them. The slot used during emerging a package should
> depend only on WX_GTK_VER in the ebuild, and must not depend on which
> slot is currently eselected. Does wxwidgets.eclass guarantee this?


According to the eclass implementation, it sets a variable that the
wxwidgets eselect wrapper then respects as an override to ignore
whatever has been eselected, and use the overridden version.

I would, anyways, assume that the eclass does what it's supposed to:

"""
More specifically, this eclass controls the configuration chosen by the
${ESYSROOT}/usr/bin/wx-config wrapper.
"""


-- 
Eli Schwartz

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 18399 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 963 bytes --]

Re: [gentoo-dev] questions about wxwidgets.eclass

[Andrey Grozin]

[-- Attachment #1: Type: text/plain, Size: 744 bytes --]

On Wed, 3 Jul 2024, Eli Schwartz wrote:
> On 7/3/24 12:19 AM, Andrey Grozin wrote:
>> 1. From which phase function should setup-wxwidgets be called?
>> The current statistics of the packages in the tree is:
>> src_configure 66
>> src_prepare   16
>> pkg_setup      6
>> pkg_prepare    1
>> Does this mean that one of these groups is right, and the other 3 ones
>> are wrong and should be fixed?
> Well, the eclass docs *literally* state the answer:
> https://devmanual.gentoo.org/eclass-reference/wxwidgets.eclass/
> """
> Call this in your ebuild to set up the environment for wxGTK in
> src_configure.
> """
Thank you. I've fixed my packages, and filed bugs about other packages 
calling setup-wxwidgets from somewhere else.

Andrey

Re: [gentoo-dev] questions about wxwidgets.eclass

[Mike Gilbert]

On Thu, Jul 4, 2024 at 8:33 AM Andrey Grozin
<grozin@woodpecker.gentoo.org> wrote:
>
> On Wed, 3 Jul 2024, Eli Schwartz wrote:
> > On 7/3/24 12:19 AM, Andrey Grozin wrote:
> >> 1. From which phase function should setup-wxwidgets be called?
> >> The current statistics of the packages in the tree is:
> >> src_configure 66
> >> src_prepare   16
> >> pkg_setup      6
> >> pkg_prepare    1
> >> Does this mean that one of these groups is right, and the other 3 ones
> >> are wrong and should be fixed?
> > Well, the eclass docs *literally* state the answer:
> > https://devmanual.gentoo.org/eclass-reference/wxwidgets.eclass/
> > """
> > Call this in your ebuild to set up the environment for wxGTK in
> > src_configure.
> > """
> Thank you. I've fixed my packages, and filed bugs about other packages
> calling setup-wxwidgets from somewhere else.

It looks like you mass-filed a couple dozen bugs, but left them
assigned to bug-wranglers.

Please assign your own bug reports, especially when files en-masse.

Re: [gentoo-dev] questions about wxwidgets.eclass

[Andrey Grozin]

On Fri, 5 Jul 2024, Mike Gilbert wrote:
> It looks like you mass-filed a couple dozen bugs, but left them
> assigned to bug-wranglers.
>
> Please assign your own bug reports, especially when files en-masse.
OK, I've assigned them to the corresponding maintainers. Except 2 ones 
which are maintainer-needed. To whom assign them?

I've also filed a thacker bug https://bugs.gentoo.org/935668 to keep track 
on the progress.

Andrey

Re: [gentoo-dev] questions about wxwidgets.eclass

[Mike Gilbert]

On Sat, Jul 6, 2024 at 9:45 AM Andrey Grozin
<grozin@woodpecker.gentoo.org> wrote:
>
> On Fri, 5 Jul 2024, Mike Gilbert wrote:
> > It looks like you mass-filed a couple dozen bugs, but left them
> > assigned to bug-wranglers.
> >
> > Please assign your own bug reports, especially when files en-masse.
> OK, I've assigned them to the corresponding maintainers. Except 2 ones
> which are maintainer-needed. To whom assign them?
>
> I've also filed a thacker bug https://bugs.gentoo.org/935668 to keep track
> on the progress.

There's a maintainer-needed@g.o bugzilla account for that. I assigned
the 2 bugs you mentioned.

Thanks for taking care of it!