Re: [gentoo-dev] [PATCH 1/2] linux-info.eclass: Drop temporary fix for powerpc

[Ionen Wolkens <ionen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

On Mon, Jul 01, 2024 at 11:36:01PM +0200, Ulrich Müller wrote:
> Apparently there is no reference to a .tmp_gas_check file or to a TOUT
> variable in Linux sources any more.
> 
> Bug: https://bugs.gentoo.org/75034#c14
> Signed-off-by: Ulrich Müller <ulm@gentoo.org>
> ---
>  eclass/linux-info.eclass | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass
> index 9449a6359d2a..90982445fdab 100644
> --- a/eclass/linux-info.eclass
> +++ b/eclass/linux-info.eclass
> @@ -170,12 +170,6 @@ KERNEL_DIR="${KERNEL_DIR:-${ROOT%/}/usr/src/linux}"
>  inherit toolchain-funcs
>  [[ ${EAPI} == 6 ]] && inherit eapi7-ver
>  
> -# bug #75034
> -case ${ARCH} in
> -	ppc)	BUILD_FIXES="${BUILD_FIXES} TOUT=${T}/.tmp_gas_check";;
> -	ppc64)	BUILD_FIXES="${BUILD_FIXES} TOUT=${T}/.tmp_gas_check";;
> -esac

On a side-note, it was further a no-op for linux-mod-r1 which opted to
intentionally ignore BUILD_FIXES (variable is currently read by kernel-2
and linux-mod-r0) and nobody complained.

If wanted, technically all references of BUILD_FIXES could probably be
removed from eclasses given (normally) nothing sets that variable beside
that ppc workaround. It was also undocumented and more like a private
variable.

Albeit some ebuilds (like the pre-linux-mod-r1 lttng-modules ebuild)
and users have wrongly used it, so it could break some spacebar heating.
No real need to bother with linux-mod.eclass either way given it's due
for eventual removal.
-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]