From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0256015817D for ; Tue, 4 Jun 2024 18:38:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E2384E2B95; Tue, 4 Jun 2024 18:37:59 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 96E9EE2B91 for ; Tue, 4 Jun 2024 18:37:59 +0000 (UTC) Date: Tue, 4 Jun 2024 14:37:56 -0400 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Cc: Florian Schmaus Subject: Re: [gentoo-dev] [PATCH 1/4] readme.gentoo-r1.eclass: display readme if content changed (or fresh install) Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org, Florian Schmaus References: <20240109083914.242561-1-flow@gentoo.org> <20240602135716.66992-1-flow@gentoo.org> <20240602135716.66992-2-flow@gentoo.org> <90350087-100f-4ca1-a9a5-b714d82b2d9a@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JOnjVvHbwxhGEZvQ" Content-Disposition: inline In-Reply-To: X-Archives-Salt: 1fb2f5c5-5cef-4446-9c51-e97a6365df42 X-Archives-Hash: 4fcae29a50e13ebf3c4c45ada1e817de --JOnjVvHbwxhGEZvQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 04, 2024 at 07:45:39PM +0200, Ulrich Mueller wrote: > In any case, the above size considerations aren't important. My main > point is that the code is getting way too complicated for the simple > task of printing a few lines in pkg_postinst. Have to say that this is mostly how I feel as well. Not that I followed this whole conversation in full. That aside, with all this talk of using the installed README.gentoo, note that the file may not even be there because of FEATURES=3D"nodoc". Albeit could just assume it's unchanged in these cases. Don't know if idea came up in this thread before but, if *really* had to implement a mechanic to display the README.gentoo again on changes, think I'd personally add an optional version variable/argument that could be bumped by the ebuild maintainer whenever the README is changed. Then if the version it's replacing is older than that it'll display it again with a notice explaining that it changed. There are some limitations to this approach but well, e.g. - won't work without a bump/revbump to compare with - maintainer might forget to set the version after changes - version won't mean as much if update the README in all ebuild versions at once, and can't tell what's actually been seen (might cause occasional see-it-again when stabilizing) - can't display a diff if wanted one, not that the hash approach could do that either --=20 ionen --JOnjVvHbwxhGEZvQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmZfXwMACgkQskQGsLCs QzSN3gf+MwTHKyNDqhgokBPG98QKxaJ9TleG89ZEV1k68EqfEP6VsUhUVBzg+g10 TGmAZKrVzluw9yIcTt4skhXrmam93PuyUB65KRZANbE+tZ81Necw/aPHrRTWQT6l Dosln3/xG9dCgyv5MlYcLLAsRi1WCj/bKmta8S+8ln9mImLAZzL65hVfLILXwEBa NGKH/1gdKxMLwNecK3ZX1RmHOhGkZ1elV+wA0Q3sqT347PeWVhO/46YFqlJz8vvE C4vtghDxVGChNIqwFykMjpP9TqsvZcXPOu9jTkjIjG50VRHSsgS+NykAwCP7Ft1G RyNxtTGPpO47g3luOIgOZxq0QtyoWw== =dmo7 -----END PGP SIGNATURE----- --JOnjVvHbwxhGEZvQ--