From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 41F5B158041 for ; Fri, 29 Mar 2024 04:55:02 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5A95CE2A34; Fri, 29 Mar 2024 04:54:57 +0000 (UTC) Received: from cloudsdale.the-delta.net.eu.org (cloudsdale.the-delta.net.eu.org [138.201.117.120]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B20BFE2A2D for ; Fri, 29 Mar 2024 04:54:56 +0000 (UTC) Received: by cloudsdale.the-delta.net.eu.org (OpenSMTPD) with ESMTP id 3d8e21db for ; Fri, 29 Mar 2024 04:54:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=hacktivis.me; h=date :from:to:message-id:references:mime-version:content-type :in-reply-to; s=20240308_115322; bh=RLUohEyyOO6x7CKZcQqxVWe2GzIa h4PEwZcfUuSGJpQ=; b=vTMzqwJZIDJvFAeHuCKALAaMYzuzkA732l2A5m/MwwG7 Bj13j3XO+ownqgPHe1n82UurgJPVmkSHU1vfY1r/Km4i4aqE4ufYtKkzWFc/EUZQ X7awoGeO24s6B0P1DG5F6Leev8n0KTH5Xrv0u31UQdYJkxMz5yOGRIAHl9+ltgdJ HI+jr6BBFeoms2t/tUMD9ALyFlGfQUyEP6F7433sUQXTq5+gp8iRmRANpIw4f+AT mGuLa0CPNcHTrPUA7HMT35Q6RlNX43gd8lwP5kbavF9hkosuU3bLkkZ6vetUrDII 9aBvVu2eGfU7jnR+EH7oEGpM1z61+6FuVUkSBj9Fkl0C35jCTTZBtfeLs3jbkQu9 8OQgHvrulyvuTnuiWtjz7jN2JWvlilD8vTgI6yy3iBCura3zHiR4hL9HLZOnBEyB ltu5vVHnQ6hhjaAU6OtqwMjRihILmJeuRtaOKGbuJeIC7ZWKu1/GO+i7DxiWfVg0 gGtBOIPa/JWbk6VEj98hu/VJjbWQGhBTt1di17594ERIJmXNnFI5ewEdhVaHauie QV3VfOYqBwO6b0b1Ykym705z+0xm08QJTsnSFx4NsxCF4eHpvYdowX3UCmoQhPbL WDXWB9K+Gi70BHSBSrFO3BlLoOQXh/noivvDXgWyv5xf1MV/qw2pH17GH6fZ8PY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=hacktivis.me; h=date:from:to :message-id:references:mime-version:content-type:in-reply-to; q= dns; s=20240308_115322; b=wRG0/swc58RRT7sJN6r+fTsduT8JBs4yTTjDVv +1rH2rVxk5Z57+FAziYBR8XJhFM4luvNr41+XHoCj1USJgR+z6GIhyy5iEoFfEQz hQzARuzQBUx2OhkqePaI1VGmwl3bu8Qm6HsK7L8/OcpdzGg46eKwqBXtq6TyaHFR 4EDUa6riXTxoadgKj66CPhBJLpGzJkNOOK7VkuezjdJnF8qyKZDW5b+G+MtL/B3l orLECl1+OMt+tGmRo2tJr67xd+xFP4onium66/hEkbY3wPFQPXYVDIXQjuvnW7KM KVipqL547qtjJxyrK5GyyZ7JuDAYS6rvxvqbtEIgVFPASZH7m1j6pvE+MYmtbQ7n hcykGNVSrRyzLCNRh8Zlmf52MXpUpgFZnn+Ed6GyD4hdoFWNev3SVoo3cD9KPOPp /k+Z+z00cJPdk30k16d8ClnuxNr4g7BZ571DUNRWRLp/xAwz0ie1TuzNm4aRdoVo OdB50NWVniP+hydn8s/qtOCMAbCx/Y+Zd78bIoln4B1OGiw2MY0U8/U/oyEB9dmv Cv+eaElvH0cbyiNGghyjPlzvsKwXsiDz8MGnsIKGur2ywvrTmfivMqvs8E2VPSjq 8alSu+9v84G5NCxqw5gAVuZH1FtTfXIJd9LySzH2z188DphRuus/zgIXLKl0a1CZ Fa5q0= Received: from localhost (cloudsdale.the-delta.net.eu.org [local]) by cloudsdale.the-delta.net.eu.org (OpenSMTPD) with ESMTPA id b84db01e for ; Fri, 29 Mar 2024 04:54:55 +0000 (UTC) Date: Fri, 29 Mar 2024 05:54:54 +0100 From: "Haelwenn (lanodan) Monnier" To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: make the FHS paths warning easier to read Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20240329035439.11381-1-eschwartz93@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240329035439.11381-1-eschwartz93@gmail.com> X-Archives-Salt: 70019497-233f-4a41-917c-ddc2accf4731 X-Archives-Hash: f06896efbe0e9c9f09fa535ea5b31675 [2024-03-28 23:54:35-0400] Eli Schwartz: > * QA Notice: The ebuild is installing to one or more unexpected paths: > * > * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/legion_prof_files > * /var/tmp/portage/sys-cluster/legion-9999/image/usr/bin/serializer_examples > * > * Please fix the ebuild to use correct FHS/Gentoo policy paths. > >This message is hard to understand. Is it saying that the resulting >package contains files prefixed with ${D} which would be immensely >broken? Is it saying that these paths are *directories* and the FHS does >not approve of directories in /usr/bin/*/? > >In fact, it's the latter. Fix this in two ways: > >- clarify that it's an unexpected directory, not just some kind of path I guess it would also make sense to have a trailing slash as extra indication of it being a directory like `ls -F` does. >- strip ${D} so that people can better visualize what sort of path gets > installed. This has the downside of not being able to copy/paste the > path in order to inspect the image directory, but I think this is a > very small downside. Usually by the time you see this message, portage > has cleaned up. And if it hasn't, you can still copy/paste that from: > > Completed installing sys-cluster/legion-9999 into /var/tmp/portage/sys-cluster/legion-9999/image Could maybe be confusable with installers not supporting DESTDIR though (although the sandbox messages look *very* different).