From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DED50158015 for ; Sat, 30 Dec 2023 15:27:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2DC382BC048; Sat, 30 Dec 2023 15:27:08 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id DC6F72BC023 for ; Sat, 30 Dec 2023 15:27:07 +0000 (UTC) Date: Sat, 30 Dec 2023 10:27:04 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Cc: =?utf-8?B?TWljaGHFgiBHw7Nybnk=?= Subject: Re: [gentoo-dev] [PATCH 2/2] linux-mod-r1.eclass: Explicitly check for missing zstd Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org, =?utf-8?B?TWljaGHFgiBHw7Nybnk=?= References: <20231230050716.127184-1-mgorny@gentoo.org> <20231230050716.127184-2-mgorny@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="z91qKUpPxhNQ9rtq" Content-Disposition: inline In-Reply-To: <20231230050716.127184-2-mgorny@gentoo.org> X-Archives-Salt: 106920cc-d9a1-4d4b-969b-0bf33c48b275 X-Archives-Hash: aa97de886d1bc4dc61394db7701a6086 --z91qKUpPxhNQ9rtq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 30, 2023 at 06:07:16AM +0100, Micha=C5=82 G=C3=B3rny wrote: > Signed-off-by: Micha=C5=82 G=C3=B3rny > --- > eclass/linux-mod-r1.eclass | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass > index b6be4ba8a16d..4de2e3f89995 100644 > --- a/eclass/linux-mod-r1.eclass > +++ b/eclass/linux-mod-r1.eclass > @@ -855,6 +855,9 @@ _modules_process_compress() { > compress=3D(gzip) > fi > elif linux_chkconfig_present MODULE_COMPRESS_ZSTD; then > + if ! type -P zstd &>/dev/null; then > + die "zstd not found, please install app-arch/zstd or disable USE=3Dmo= dules-compress" > + fi As mentioned on IRC, I don't think we overly need an extra check just for this. Users have explicitly enabled zstd-compression that they needed for their kernel (meaning they at least had zstd), and if it somehow dies with "zstd: command not found" I think it's self-explanatory. Hard for it to be missing even if it's not in @system too given portage currently depends on it. Not to say it couldn't, or change. > compress=3D(zstd -qT"$(makeopts_jobs)" --rm) > else > die "USE=3Dmodules-compress enabled but no MODULE_COMPRESS* configured" > --=20 > 2.43.0 >=20 >=20 --=20 ionen --z91qKUpPxhNQ9rtq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmWQNscACgkQskQGsLCs QzRH6wgAnjTGkBF+Z6EHtxlNmoam8LfYjyC/qWsSyG6oD+Ca2b5Q70+Vh46AVsyI IMx7YOhqwFuKFsIx/LEig4HNAJV/bwtQufA5f4rWmVEApu2RPvO8mu2Me9SHi647 CS60a7rr+MRBSk/Xoh+Sa/e9flmNSGc/kcLcM+sGnwkF/BGWGWP+z9CmW87oNnQM U3QvzDuM+vxTQnrevTqbTJ+BWFkuGEQO/iVtqDonFMbx2ebJMiw98ctny23lE+Om qZ5mdCv3dcuezaE3FERDlJCpekToY7r9onxUCuvwPFX2n7KZZIwqDZmVsc+eON1x WXOsD/KH3pNJIibqdxN+skjxp4Lpaw== =YOHD -----END PGP SIGNATURE----- --z91qKUpPxhNQ9rtq--