Re: [gentoo-dev] [PATCH 2/2] linux-mod-r1.eclass: Explicitly check for missing zstd

[Ionen Wolkens <ionen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

On Sat, Dec 30, 2023 at 06:07:16AM +0100, Michał Górny wrote:
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  eclass/linux-mod-r1.eclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/eclass/linux-mod-r1.eclass b/eclass/linux-mod-r1.eclass
> index b6be4ba8a16d..4de2e3f89995 100644
> --- a/eclass/linux-mod-r1.eclass
> +++ b/eclass/linux-mod-r1.eclass
> @@ -855,6 +855,9 @@ _modules_process_compress() {
>  			compress=(gzip)
>  		fi
>  	elif linux_chkconfig_present MODULE_COMPRESS_ZSTD; then
> +		if ! type -P zstd &>/dev/null; then
> +			die "zstd not found, please install app-arch/zstd or disable USE=modules-compress"
> +		fi

As mentioned on IRC, I don't think we overly need an extra check just
for this. Users have explicitly enabled zstd-compression that they
needed for their kernel (meaning they at least had zstd), and if it
somehow dies with "zstd: command not found" I think it's
self-explanatory.

Hard for it to be missing even if it's not in @system too given portage
currently depends on it. Not to say it couldn't, or change.

>  		compress=(zstd -qT"$(makeopts_jobs)" --rm)
>  	else
>  		die "USE=modules-compress enabled but no MODULE_COMPRESS* configured"
> -- 
> 2.43.0
> 
> 

-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]