From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 47500158013 for ; Wed, 6 Dec 2023 07:44:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6F7542BC023; Wed, 6 Dec 2023 07:44:05 +0000 (UTC) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3F4E22BC016 for ; Wed, 6 Dec 2023 07:44:05 +0000 (UTC) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1d03f90b0cbso12430855ad.1 for ; Tue, 05 Dec 2023 23:44:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701848644; x=1702453444; darn=lists.gentoo.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Z0lL1pRzql3OGjDp6jSmm5bXnTRivcStnCgeOiE80qE=; b=C3EKSCykiIRYs/6Usz+djCHDN3ko7JSr+w/Wsqb1zXECydalCZl6XRPPRuOVPwLMwT miC3+pFK09w4jgLiMzkMGwT9wCCNR1mqHKVoXNvY+y/9XYXBSs3qAJ+pmNcvLETE9FoL FVRAI5g8aDJ4CKgE4945/SeacBk5Rci4D53XY9gkZ/u/3lSItWlzlFVQsf0mPKnzMKWz jtorDwlP+9LwiknLHjXk2JeyyfvI9AvG2/CbBUI5KdGDGPLur8f9gTwrj03FXGwS30zd RMsMfPv4WDcmdGHB4fMr6nbMRL5cJWsJ7RD7lqym04bQJdVaZB3OiYi9/q9PTQcn19vp 0d4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701848644; x=1702453444; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z0lL1pRzql3OGjDp6jSmm5bXnTRivcStnCgeOiE80qE=; b=PRMcwGLKfUfLdD5ZpsWf8wZeCwZ3Pz1kRtjGskhfbLNq1X7V3UaEpz/nR69a6Y+qs6 ts2oAf1MUZ7HfB2MbyQH3+AbyFxBR8oB6IavY+Mvm4+vCmlzi7sDqNBKNvFJDOVxEAK0 Xq1RhBKRLWmwFRUoDuukl6gHEp8cNAPVAVasEBKZ+Gee4YCbfe819V3w3crV1CcsrFWq ddhkqyp9jNffinfB9YMmPajjBltBe0z7yJZgO2F0RxsG2UqKV1LzRyMIe/dRGi3R8+ZZ udEH6jaqvua0xZwUyWuN0/wDzi5OjqwvrvrHUmb6MMLv8kjNCo2dJoh0lfinkXmzC9Xt gZow== X-Gm-Message-State: AOJu0Yw45aBWYdrb0pJEHW2ejCcowadoXa/tYpG2ou9uNGBy8veb/IOC TdsrT0VJPmE1Ux1tMHSG/Ow= X-Google-Smtp-Source: AGHT+IGENox1wKuy0vm9A5dLJ8C9ySzS4aAgpL2qRYF6rvOs9DMf215hnI2JHRooLRw2L39ilbQ0Vg== X-Received: by 2002:a17:903:190:b0:1d0:9323:e43a with SMTP id z16-20020a170903019000b001d09323e43amr990361plg.0.1701848644253; Tue, 05 Dec 2023 23:44:04 -0800 (PST) Received: from localhost ([2402:f000:4:1008:809:ffff:ffe6:8826]) by smtp.gmail.com with ESMTPSA id h4-20020a170902eec400b001d1d1ef8be6sm385987plb.267.2023.12.05.23.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 23:44:03 -0800 (PST) Date: Wed, 6 Dec 2023 15:44:02 +0800 From: WuYiyang To: Benda Xu Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/2] rocm.eclass: Fix the xnack feature for gfx90a Message-ID: References: <20231117032201.5213-1-xgreenlandforwyy@gmail.com> <87msv06os7.fsf@aurora.g.airelinux.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87msv06os7.fsf@aurora.g.airelinux.org> User-Agent: Mutt/2.2.12 (2023-09-09) X-Archives-Salt: 473cc4d6-8ea4-4218-8840-fa7989cfdb28 X-Archives-Hash: 67d199de29eb3bea53b46006f89f8303 On Mon, Nov 27, 2023 at 08:08:40AM +0800, Benda Xu wrote: > Hi Yiyang, > > Yiyang Wu writes: > > > Upstream usually ships 2 version: gfx90a:xnack-, gfx90a:xnack+. Although > > a single gfx90a should have maximum compatibility, According to [1,2], > > compile with xnack+/xnack- may have better performance on xnack > > enabled/disabled GPUs. Therefore we ship both the target, align with > > upstream. gfx900 is also appended with :xnack- to align with upstream > > default. > > > [1] https://llvm.org/docs/AMDGPUUsage.html#target-features > > [2] https://docs.olcf.ornl.gov/systems/crusher_quick_start_guide.html#compiling-hip-kernels-for-specific-xnack-modes > > So, you want to add a new ABI to gfx90a for experimental xnack feature. > I suggest make it gfx90a with gfx90a_xnack, instead of > "gfx90a_noxnack" for consistency the existing naming scheme. Previously the gfx90a is appended with :xnack+ feature: ```bash case ${gpu_target} in gfx906|gfx908) target_feature=:xnack- ;; gfx90a) target_feature=:xnack+ ;; *) ;; esac ``` That means actually we are shipping gfx90a_xnack originally, without shipping the xnack disabled build. So maybe you mean adding a new ABI gfx90a_noxnack, while keeping gfx90a_xnack as its original name gfx90a? > > With this minimal modification, the remaining cards such as gfx906 and > gfx908 that support xnack could be updated incrementally. Yes, although ROCm upstream does not ship the xnack supported build of math libraries, for unknown reasons. There's no public documentation about this, while some discussions exists [1] [1] https://github.com/RadeonOpenCompute/ROCm/issues/2358 Best, Yiyang Wu