Re: [gentoo-dev] [PATCH] use.desc: Make `native-extensions` flag global

[Oskari Pirhonen <xxc3ncoredxx@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]

On Sun, Nov 05, 2023 at 06:42:35 +0100, Michał Górny wrote:
> Make the `native-extensions` flag global.  It is used in 15 Python
> packages to enable building optional C extensions, though the global
> description also allows for other "native" and "pure" languages.
> 
> In 9 cases, the flag description explicitly mentions "speedups", so this
> is the primary case used in global description.  There is one case
> of the extension providing extra features, and the remaining cases
> do not explain its role.
> 
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
>  profiles/use.desc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/profiles/use.desc b/profiles/use.desc
> index d8f97958e900..01915ae78918 100644
> --- a/profiles/use.desc
> +++ b/profiles/use.desc
> @@ -212,6 +212,7 @@ musicbrainz - Lookup audio metadata using MusicBrainz community service (musicbr
>  mysql - Add mySQL Database support
>  mysqli - Add support for the improved mySQL libraries
>  nas - Add support for network audio sound
> +native-extensions - Build native (C, Rust) extensions in additional to pure (e.g. Python) code (usually speedups)

I'd say "(e.g. C, Rust)", similarly to what you did later, so that
people don't think it means only C or Rust extensions get built.

- Oskari

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]