* [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag
@ 2023-09-10 15:45 Rafael Kitover
2023-09-10 15:45 ` [gentoo-dev] [PATCH 2/2] x11-libs/wxGTK: egl USE flag for OpenGL on Wayland Rafael Kitover
2023-09-10 18:28 ` [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Ionen Wolkens
0 siblings, 2 replies; 6+ messages in thread
From: Rafael Kitover @ 2023-09-10 15:45 UTC (permalink / raw
To: gentoo-dev; +Cc: x11, Rafael Kitover
Add the egl USE flag and description to profiles/use.desc and remove egl
flag descriptions from all ebuild metadata.xml files that contain it.
PR: https://github.com/gentoo/gentoo/pull/32452
Signed-off-by: Rafael Kitover <rkitover@gmail.com>
---
dev-games/ogre/metadata.xml | 1 -
dev-games/openscenegraph-openmw/metadata.xml | 1 -
dev-games/openscenegraph/metadata.xml | 1 -
dev-qt/qtgui/metadata.xml | 1 -
media-gfx/openscad/metadata.xml | 3 ---
media-libs/clutter/metadata.xml | 1 -
media-libs/gst-plugins-bad/metadata.xml | 1 -
media-libs/gst-plugins-base/metadata.xml | 1 -
media-libs/libepoxy/metadata.xml | 3 ---
media-libs/libva-compat/metadata.xml | 1 -
media-libs/waffle/metadata.xml | 1 -
media-plugins/gst-plugins-gtk/metadata.xml | 1 -
media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
media-video/mpv/metadata.xml | 1 -
profiles/use.desc | 1 +
15 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/dev-games/ogre/metadata.xml b/dev-games/ogre/metadata.xml
index 10134612ebf8..212b8c99e8fe 100644
--- a/dev-games/ogre/metadata.xml
+++ b/dev-games/ogre/metadata.xml
@@ -86,7 +86,6 @@ Exporters
<flag name="deprecated" restrict=">dev-games/ogre-13">
Build deprecated nodeless positioning of Lights and Cameras.
</flag>
- <flag name="egl">Use egl instead of glx</flag>
<flag name="fine-granularity" restrict="~dev-games/ogre-2.1">
Enable fine light mask granularity. This impacts on performance and should
not be enabled unless an application really needs it.
diff --git a/dev-games/openscenegraph-openmw/metadata.xml b/dev-games/openscenegraph-openmw/metadata.xml
index 26f01f3f105e..95b4405f0657 100644
--- a/dev-games/openscenegraph-openmw/metadata.xml
+++ b/dev-games/openscenegraph-openmw/metadata.xml
@@ -27,7 +27,6 @@
<use>
<flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
<flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
<flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
<flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
diff --git a/dev-games/openscenegraph/metadata.xml b/dev-games/openscenegraph/metadata.xml
index 88b68f751d28..049f3df3a410 100644
--- a/dev-games/openscenegraph/metadata.xml
+++ b/dev-games/openscenegraph/metadata.xml
@@ -15,7 +15,6 @@
<use>
<flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
<flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
<flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
<flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
diff --git a/dev-qt/qtgui/metadata.xml b/dev-qt/qtgui/metadata.xml
index ab06e044872c..55e237a8d1ef 100644
--- a/dev-qt/qtgui/metadata.xml
+++ b/dev-qt/qtgui/metadata.xml
@@ -6,7 +6,6 @@
<name>Gentoo Qt Project</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL integration</flag>
<flag name="eglfs">Build the EGL Full Screen/Single Surface platform plugin</flag>
<flag name="evdev">Enable support for input devices via evdev</flag>
<flag name="ibus">Build the IBus input method plugin</flag>
diff --git a/media-gfx/openscad/metadata.xml b/media-gfx/openscad/metadata.xml
index 0b965cbf4ac8..72d213f9fe70 100644
--- a/media-gfx/openscad/metadata.xml
+++ b/media-gfx/openscad/metadata.xml
@@ -21,9 +21,6 @@
Mac OS X.
</longdescription>
<use>
- <flag name="egl">
- Build using EGL instead of GLX
- </flag>
<flag name="experimental">
Enable experimental features
</flag>
diff --git a/media-libs/clutter/metadata.xml b/media-libs/clutter/metadata.xml
index c945cf9a5946..bb66dfa52e7a 100644
--- a/media-libs/clutter/metadata.xml
+++ b/media-libs/clutter/metadata.xml
@@ -6,7 +6,6 @@
<name>Gentoo GNOME Desktop</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL backend.</flag>
<flag name="gtk">Use gdk-pixbuf from <pkg>x11-libs/gtk+</pkg> as image rendering backend</flag>
</use>
<upstream>
diff --git a/media-libs/gst-plugins-bad/metadata.xml b/media-libs/gst-plugins-bad/metadata.xml
index 6749b9b02477..0f38fc62ad85 100644
--- a/media-libs/gst-plugins-bad/metadata.xml
+++ b/media-libs/gst-plugins-bad/metadata.xml
@@ -7,7 +7,6 @@
</maintainer>
<use>
<flag name="bzip2">Enable bzip2 encoder/decoder plugin</flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="gles2">Enable GLES2 support</flag>
<flag name="qsv">Enable Intel Quick Sync Video using the <pkg>media-libs/oneVPL</pkg> dispatcher</flag>
</use>
diff --git a/media-libs/gst-plugins-base/metadata.xml b/media-libs/gst-plugins-base/metadata.xml
index f540928582cf..179c5151b43c 100644
--- a/media-libs/gst-plugins-base/metadata.xml
+++ b/media-libs/gst-plugins-base/metadata.xml
@@ -7,7 +7,6 @@
</maintainer>
<use>
<flag name="gbm">Enable Graphics Buffer Manager based EGL windowing system support (requires egl and at least one of gles or opengl)</flag>
- <flag name="egl">Enable EGL platform support</flag>
<flag name="gles2">Enable OpenGL library and plugin via GLESv2 API (requires egl)</flag>
<flag name="ivorbis">Enable integer based vorbis decoder</flag>
<flag name="opengl">Enable OpenGL library and plugin via desktop OpenGL API</flag>
diff --git a/media-libs/libepoxy/metadata.xml b/media-libs/libepoxy/metadata.xml
index e092005ad115..509b7d255563 100644
--- a/media-libs/libepoxy/metadata.xml
+++ b/media-libs/libepoxy/metadata.xml
@@ -5,9 +5,6 @@
<email>x11@gentoo.org</email>
<name>X11</name>
</maintainer>
- <use>
- <flag name="egl">Enable EGL support.</flag>
- </use>
<upstream>
<remote-id type="github">anholt/libepoxy</remote-id>
</upstream>
diff --git a/media-libs/libva-compat/metadata.xml b/media-libs/libva-compat/metadata.xml
index e454a2831910..455cac07f59c 100644
--- a/media-libs/libva-compat/metadata.xml
+++ b/media-libs/libva-compat/metadata.xml
@@ -6,7 +6,6 @@
<name>James Le Cuirot</name>
</maintainer>
<use>
- <flag name="egl">Enables EGL support.</flag>
<flag name="drm">Enables VA/DRM API support.</flag>
</use>
<upstream>
diff --git a/media-libs/waffle/metadata.xml b/media-libs/waffle/metadata.xml
index 7d510e7a6781..4ee146af9dcb 100644
--- a/media-libs/waffle/metadata.xml
+++ b/media-libs/waffle/metadata.xml
@@ -6,7 +6,6 @@
<name>X11</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL support</flag>
<flag name="gbm">Enable support for the Generic Buffer Manager (gbm)</flag>
<flag name="wayland">Enable Wayland support</flag>
</use>
diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-plugins/gst-plugins-gtk/metadata.xml
index 7235f1bab7ba..f3b18c11bcfc 100644
--- a/media-plugins/gst-plugins-gtk/metadata.xml
+++ b/media-plugins/gst-plugins-gtk/metadata.xml
@@ -6,7 +6,6 @@
<name>GStreamer package maintainers</name>
</maintainer>
<use>
- <flag name="egl">Enable EGL platform usage</flag>
<flag name="gles2">Enable gtkglsink OpenGL sink based on GLESv2 API</flag>
<flag name="opengl">Enable gtkglsink OpenGL sink based on desktop OpenGL API</flag>
</use>
diff --git a/media-plugins/gst-plugins-vaapi/metadata.xml b/media-plugins/gst-plugins-vaapi/metadata.xml
index 3f726dfa99ea..6997730f1472 100644
--- a/media-plugins/gst-plugins-vaapi/metadata.xml
+++ b/media-plugins/gst-plugins-vaapi/metadata.xml
@@ -7,7 +7,6 @@
</maintainer>
<use>
<flag name="drm">Enable DRM renderer</flag>
- <flag name="egl">Enable EGL support</flag>
<flag name="gles2">Enable GLESv2 and GLESv3 support</flag>
</use>
</pkgmetadata>
diff --git a/media-video/mpv/metadata.xml b/media-video/mpv/metadata.xml
index 7ae1bd6e2875..e6f3a0a8f95c 100644
--- a/media-video/mpv/metadata.xml
+++ b/media-video/mpv/metadata.xml
@@ -10,7 +10,6 @@
<flag name="bluray">Enable playback of Blu-ray filesystems</flag>
<flag name="cli">Enable the command-line player</flag>
<flag name="drm">Enable Kernel Mode Setting / Direct Rendering Manager based video outputs</flag>
- <flag name="egl">Enable support for various EGL-based video outputs / backends</flag>
<flag name="gamepad">Enable gamepad input support</flag>
<flag name="libmpv">Enable the shared library and headers (used by frontends / plugins)</flag>
<flag name="libplacebo">Enable support for GPU accelerated video rendering with <pkg>media-libs/libplacebo</pkg></flag>
diff --git a/profiles/use.desc b/profiles/use.desc
index 6034f3bf6fc3..4a8f5618f7ca 100644
--- a/profiles/use.desc
+++ b/profiles/use.desc
@@ -70,6 +70,7 @@ dvb - Add support for DVB (Digital Video Broadcasting)
dvd - Add support for DVDs
dvdr - Add support for DVD writer hardware (e.g. in xcdroast)
eds - Enable support for Evolution-Data-Server (EDS)
+egl - Enable support for EGL OpenGL, necessary on Wayland
elogind - Enable session tracking via sys-auth/elogind
emacs - Add support for GNU Emacs
emboss - Add support for the European Molecular Biology Open Software Suite
--
2.42.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [gentoo-dev] [PATCH 2/2] x11-libs/wxGTK: egl USE flag for OpenGL on Wayland
2023-09-10 15:45 [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Rafael Kitover
@ 2023-09-10 15:45 ` Rafael Kitover
2023-09-10 16:01 ` Sam James
2023-09-10 18:28 ` [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Ionen Wolkens
1 sibling, 1 reply; 6+ messages in thread
From: Rafael Kitover @ 2023-09-10 15:45 UTC (permalink / raw
To: gentoo-dev; +Cc: x11, Rafael Kitover
EGL is the only available OpenGL support on Wayland, so add the egl USE
flag and do not add --disable-glcanvasegl to configure args if it is
enabled.
Explain the rationale for GLX being the default and the egl USE flag, as
well as the upstream issue link to improve the situation in the ebuild
comments.
PR: https://github.com/gentoo/gentoo/pull/32452
Signed-off-by: Rafael Kitover <rkitover@gmail.com>
---
x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild b/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild
index 1411650e6df9..b6d95a3df4a5 100644
--- a/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild
+++ b/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild
@@ -21,7 +21,7 @@ S="${WORKDIR}/wxWidgets-${PV}"
LICENSE="wxWinLL-3 GPL-2 doc? ( wxWinFDL-3 )"
SLOT="${WXRELEASE}"
KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~loong ~mips ~ppc ~ppc64 ~riscv ~sparc ~x86 ~amd64-linux ~x86-linux"
-IUSE="+X curl doc debug keyring gstreamer libnotify +lzma opengl pch sdl +spell test tiff wayland webkit"
+IUSE="+X curl doc debug keyring gstreamer libnotify +lzma opengl egl pch sdl +spell test tiff wayland webkit"
REQUIRED_USE="test? ( tiff ) tiff? ( X ) spell? ( X ) keyring? ( X )"
RESTRICT="!test? ( test )"
@@ -146,8 +146,19 @@ multilib_src_configure() {
--libdir='${prefix}'/$(get_libdir)
)
- # Switch to wxGLCanvas GLX instead of EGL, resolves many OpenGL issues.
- myeconfargs+=( "--disable-glcanvasegl" )
+ # By default, we now build with the GLX GLCanvas because some software like
+ # PrusaSlicer does not yet support EGL. However, under Wayland EGL is the
+ # only working OpenGL implementation, so we allow the user to specify the
+ # egl USE flag to override this behavior and not disable the EGL GLCanvas.
+ #
+ # Upstream issue to improve this situation by instantiating the GLX
+ # GLCanvas under X11 dynamically:
+ #
+ # https://github.com/wxWidgets/wxWidgets/issues/23833
+ #
+ if ! use egl; then
+ myeconfargs+=( "--disable-glcanvasegl" )
+ fi
# debug in >=2.9
# there is no longer separate debug libraries (gtk2ud)
--
2.42.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH 2/2] x11-libs/wxGTK: egl USE flag for OpenGL on Wayland
2023-09-10 15:45 ` [gentoo-dev] [PATCH 2/2] x11-libs/wxGTK: egl USE flag for OpenGL on Wayland Rafael Kitover
@ 2023-09-10 16:01 ` Sam James
0 siblings, 0 replies; 6+ messages in thread
From: Sam James @ 2023-09-10 16:01 UTC (permalink / raw
To: gentoo-dev; +Cc: x11, Rafael Kitover
Rafael Kitover <rkitover@gmail.com> writes:
> EGL is the only available OpenGL support on Wayland, so add the egl USE
> flag and do not add --disable-glcanvasegl to configure args if it is
> enabled.
>
> Explain the rationale for GLX being the default and the egl USE flag, as
> well as the upstream issue link to improve the situation in the ebuild
> comments.
>
> PR: https://github.com/gentoo/gentoo/pull/32452
Please tag the kicad bug which kicked this off with Bug:, as well as
any other relevant ones.
We want to try not make the same mistake as the original commits
which caused all this fuss, so more detail in the commit messages
would be good (although yours reads fine, just saying if you can
think of anything else).
>
> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
> ---
> x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild b/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild
> index 1411650e6df9..b6d95a3df4a5 100644
> --- a/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild
> +++ b/x11-libs/wxGTK/wxGTK-3.2.2.1-r3.ebuild
> @@ -21,7 +21,7 @@ S="${WORKDIR}/wxWidgets-${PV}"
> LICENSE="wxWinLL-3 GPL-2 doc? ( wxWinFDL-3 )"
> SLOT="${WXRELEASE}"
> KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~hppa ~ia64 ~loong ~mips ~ppc ~ppc64 ~riscv ~sparc ~x86 ~amd64-linux ~x86-linux"
> -IUSE="+X curl doc debug keyring gstreamer libnotify +lzma opengl pch sdl +spell test tiff wayland webkit"
> +IUSE="+X curl doc debug keyring gstreamer libnotify +lzma opengl egl pch sdl +spell test tiff wayland webkit"
> REQUIRED_USE="test? ( tiff ) tiff? ( X ) spell? ( X ) keyring? ( X )"
> RESTRICT="!test? ( test )"
>
> @@ -146,8 +146,19 @@ multilib_src_configure() {
> --libdir='${prefix}'/$(get_libdir)
> )
>
> - # Switch to wxGLCanvas GLX instead of EGL, resolves many OpenGL issues.
> - myeconfargs+=( "--disable-glcanvasegl" )
> + # By default, we now build with the GLX GLCanvas because some software like
> + # PrusaSlicer does not yet support EGL. However, under Wayland EGL is the
> + # only working OpenGL implementation, so we allow the user to specify the
> + # egl USE flag to override this behavior and not disable the EGL GLCanvas.
> + #
> + # Upstream issue to improve this situation by instantiating the GLX
> + # GLCanvas under X11 dynamically:
> + #
> + # https://github.com/wxWidgets/wxWidgets/issues/23833
> + #
> + if ! use egl; then
> + myeconfargs+=( "--disable-glcanvasegl" )
> + fi
>
> # debug in >=2.9
> # there is no longer separate debug libraries (gtk2ud)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag
2023-09-10 15:45 [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Rafael Kitover
2023-09-10 15:45 ` [gentoo-dev] [PATCH 2/2] x11-libs/wxGTK: egl USE flag for OpenGL on Wayland Rafael Kitover
@ 2023-09-10 18:28 ` Ionen Wolkens
2023-09-10 18:42 ` Ionen Wolkens
1 sibling, 1 reply; 6+ messages in thread
From: Ionen Wolkens @ 2023-09-10 18:28 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 11027 bytes --]
On Sun, Sep 10, 2023 at 03:45:21PM +0000, Rafael Kitover wrote:
> Add the egl USE flag and description to profiles/use.desc and remove egl
> flag descriptions from all ebuild metadata.xml files that contain it.
>
> PR: https://github.com/gentoo/gentoo/pull/32452
>
> Signed-off-by: Rafael Kitover <rkitover@gmail.com>
> ---
> dev-games/ogre/metadata.xml | 1 -
> dev-games/openscenegraph-openmw/metadata.xml | 1 -
> dev-games/openscenegraph/metadata.xml | 1 -
> dev-qt/qtgui/metadata.xml | 1 -
> media-gfx/openscad/metadata.xml | 3 ---
> media-libs/clutter/metadata.xml | 1 -
> media-libs/gst-plugins-bad/metadata.xml | 1 -
> media-libs/gst-plugins-base/metadata.xml | 1 -
> media-libs/libepoxy/metadata.xml | 3 ---
> media-libs/libva-compat/metadata.xml | 1 -
> media-libs/waffle/metadata.xml | 1 -
> media-plugins/gst-plugins-gtk/metadata.xml | 1 -
> media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
> media-video/mpv/metadata.xml | 1 -
> profiles/use.desc | 1 +
> 15 files changed, 1 insertion(+), 18 deletions(-)
That's actually not a lot of ebuilds for a global flag. Not that it is
an issue per the devmanual (5+).
But in a lot of situations the flag is not particularly needed given
it can be enabled together with opengl without needing anything special
(aka just need libglvnd, not a special mesa[egl(+)] check).
In fact, I just removed it on qtbase not long ago, so now it only
exists on qtgui.
May remove it from mpv eventually too, it should probably be merged
into IUSE=opengl given IUSE=egl is also used for the "new" opengl
backend while IUSE=opengl is the deprecated one plus some other obscure
things.
Tend to feel libepoxy doesn't need the flag and should just enable it
like mesa did too.
Haven't really looked at the others.
>
> diff --git a/dev-games/ogre/metadata.xml b/dev-games/ogre/metadata.xml
> index 10134612ebf8..212b8c99e8fe 100644
> --- a/dev-games/ogre/metadata.xml
> +++ b/dev-games/ogre/metadata.xml
> @@ -86,7 +86,6 @@ Exporters
> <flag name="deprecated" restrict=">dev-games/ogre-13">
> Build deprecated nodeless positioning of Lights and Cameras.
> </flag>
> - <flag name="egl">Use egl instead of glx</flag>
> <flag name="fine-granularity" restrict="~dev-games/ogre-2.1">
> Enable fine light mask granularity. This impacts on performance and should
> not be enabled unless an application really needs it.
> diff --git a/dev-games/openscenegraph-openmw/metadata.xml b/dev-games/openscenegraph-openmw/metadata.xml
> index 26f01f3f105e..95b4405f0657 100644
> --- a/dev-games/openscenegraph-openmw/metadata.xml
> +++ b/dev-games/openscenegraph-openmw/metadata.xml
> @@ -27,7 +27,6 @@
> <use>
> <flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
> <flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
> - <flag name="egl">Enable EGL support</flag>
> <flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
> <flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
> <flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
> diff --git a/dev-games/openscenegraph/metadata.xml b/dev-games/openscenegraph/metadata.xml
> index 88b68f751d28..049f3df3a410 100644
> --- a/dev-games/openscenegraph/metadata.xml
> +++ b/dev-games/openscenegraph/metadata.xml
> @@ -15,7 +15,6 @@
> <use>
> <flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
> <flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
> - <flag name="egl">Enable EGL support</flag>
> <flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
> <flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
> <flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
> diff --git a/dev-qt/qtgui/metadata.xml b/dev-qt/qtgui/metadata.xml
> index ab06e044872c..55e237a8d1ef 100644
> --- a/dev-qt/qtgui/metadata.xml
> +++ b/dev-qt/qtgui/metadata.xml
> @@ -6,7 +6,6 @@
> <name>Gentoo Qt Project</name>
> </maintainer>
> <use>
> - <flag name="egl">Enable EGL integration</flag>
> <flag name="eglfs">Build the EGL Full Screen/Single Surface platform plugin</flag>
> <flag name="evdev">Enable support for input devices via evdev</flag>
> <flag name="ibus">Build the IBus input method plugin</flag>
> diff --git a/media-gfx/openscad/metadata.xml b/media-gfx/openscad/metadata.xml
> index 0b965cbf4ac8..72d213f9fe70 100644
> --- a/media-gfx/openscad/metadata.xml
> +++ b/media-gfx/openscad/metadata.xml
> @@ -21,9 +21,6 @@
> Mac OS X.
> </longdescription>
> <use>
> - <flag name="egl">
> - Build using EGL instead of GLX
> - </flag>
> <flag name="experimental">
> Enable experimental features
> </flag>
> diff --git a/media-libs/clutter/metadata.xml b/media-libs/clutter/metadata.xml
> index c945cf9a5946..bb66dfa52e7a 100644
> --- a/media-libs/clutter/metadata.xml
> +++ b/media-libs/clutter/metadata.xml
> @@ -6,7 +6,6 @@
> <name>Gentoo GNOME Desktop</name>
> </maintainer>
> <use>
> - <flag name="egl">Enable EGL backend.</flag>
> <flag name="gtk">Use gdk-pixbuf from <pkg>x11-libs/gtk+</pkg> as image rendering backend</flag>
> </use>
> <upstream>
> diff --git a/media-libs/gst-plugins-bad/metadata.xml b/media-libs/gst-plugins-bad/metadata.xml
> index 6749b9b02477..0f38fc62ad85 100644
> --- a/media-libs/gst-plugins-bad/metadata.xml
> +++ b/media-libs/gst-plugins-bad/metadata.xml
> @@ -7,7 +7,6 @@
> </maintainer>
> <use>
> <flag name="bzip2">Enable bzip2 encoder/decoder plugin</flag>
> - <flag name="egl">Enable EGL support</flag>
> <flag name="gles2">Enable GLES2 support</flag>
> <flag name="qsv">Enable Intel Quick Sync Video using the <pkg>media-libs/oneVPL</pkg> dispatcher</flag>
> </use>
> diff --git a/media-libs/gst-plugins-base/metadata.xml b/media-libs/gst-plugins-base/metadata.xml
> index f540928582cf..179c5151b43c 100644
> --- a/media-libs/gst-plugins-base/metadata.xml
> +++ b/media-libs/gst-plugins-base/metadata.xml
> @@ -7,7 +7,6 @@
> </maintainer>
> <use>
> <flag name="gbm">Enable Graphics Buffer Manager based EGL windowing system support (requires egl and at least one of gles or opengl)</flag>
> - <flag name="egl">Enable EGL platform support</flag>
> <flag name="gles2">Enable OpenGL library and plugin via GLESv2 API (requires egl)</flag>
> <flag name="ivorbis">Enable integer based vorbis decoder</flag>
> <flag name="opengl">Enable OpenGL library and plugin via desktop OpenGL API</flag>
> diff --git a/media-libs/libepoxy/metadata.xml b/media-libs/libepoxy/metadata.xml
> index e092005ad115..509b7d255563 100644
> --- a/media-libs/libepoxy/metadata.xml
> +++ b/media-libs/libepoxy/metadata.xml
> @@ -5,9 +5,6 @@
> <email>x11@gentoo.org</email>
> <name>X11</name>
> </maintainer>
> - <use>
> - <flag name="egl">Enable EGL support.</flag>
> - </use>
> <upstream>
> <remote-id type="github">anholt/libepoxy</remote-id>
> </upstream>
> diff --git a/media-libs/libva-compat/metadata.xml b/media-libs/libva-compat/metadata.xml
> index e454a2831910..455cac07f59c 100644
> --- a/media-libs/libva-compat/metadata.xml
> +++ b/media-libs/libva-compat/metadata.xml
> @@ -6,7 +6,6 @@
> <name>James Le Cuirot</name>
> </maintainer>
> <use>
> - <flag name="egl">Enables EGL support.</flag>
> <flag name="drm">Enables VA/DRM API support.</flag>
> </use>
> <upstream>
> diff --git a/media-libs/waffle/metadata.xml b/media-libs/waffle/metadata.xml
> index 7d510e7a6781..4ee146af9dcb 100644
> --- a/media-libs/waffle/metadata.xml
> +++ b/media-libs/waffle/metadata.xml
> @@ -6,7 +6,6 @@
> <name>X11</name>
> </maintainer>
> <use>
> - <flag name="egl">Enable EGL support</flag>
> <flag name="gbm">Enable support for the Generic Buffer Manager (gbm)</flag>
> <flag name="wayland">Enable Wayland support</flag>
> </use>
> diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-plugins/gst-plugins-gtk/metadata.xml
> index 7235f1bab7ba..f3b18c11bcfc 100644
> --- a/media-plugins/gst-plugins-gtk/metadata.xml
> +++ b/media-plugins/gst-plugins-gtk/metadata.xml
> @@ -6,7 +6,6 @@
> <name>GStreamer package maintainers</name>
> </maintainer>
> <use>
> - <flag name="egl">Enable EGL platform usage</flag>
> <flag name="gles2">Enable gtkglsink OpenGL sink based on GLESv2 API</flag>
> <flag name="opengl">Enable gtkglsink OpenGL sink based on desktop OpenGL API</flag>
> </use>
> diff --git a/media-plugins/gst-plugins-vaapi/metadata.xml b/media-plugins/gst-plugins-vaapi/metadata.xml
> index 3f726dfa99ea..6997730f1472 100644
> --- a/media-plugins/gst-plugins-vaapi/metadata.xml
> +++ b/media-plugins/gst-plugins-vaapi/metadata.xml
> @@ -7,7 +7,6 @@
> </maintainer>
> <use>
> <flag name="drm">Enable DRM renderer</flag>
> - <flag name="egl">Enable EGL support</flag>
> <flag name="gles2">Enable GLESv2 and GLESv3 support</flag>
> </use>
> </pkgmetadata>
> diff --git a/media-video/mpv/metadata.xml b/media-video/mpv/metadata.xml
> index 7ae1bd6e2875..e6f3a0a8f95c 100644
> --- a/media-video/mpv/metadata.xml
> +++ b/media-video/mpv/metadata.xml
> @@ -10,7 +10,6 @@
> <flag name="bluray">Enable playback of Blu-ray filesystems</flag>
> <flag name="cli">Enable the command-line player</flag>
> <flag name="drm">Enable Kernel Mode Setting / Direct Rendering Manager based video outputs</flag>
> - <flag name="egl">Enable support for various EGL-based video outputs / backends</flag>
> <flag name="gamepad">Enable gamepad input support</flag>
> <flag name="libmpv">Enable the shared library and headers (used by frontends / plugins)</flag>
> <flag name="libplacebo">Enable support for GPU accelerated video rendering with <pkg>media-libs/libplacebo</pkg></flag>
> diff --git a/profiles/use.desc b/profiles/use.desc
> index 6034f3bf6fc3..4a8f5618f7ca 100644
> --- a/profiles/use.desc
> +++ b/profiles/use.desc
> @@ -70,6 +70,7 @@ dvb - Add support for DVB (Digital Video Broadcasting)
> dvd - Add support for DVDs
> dvdr - Add support for DVD writer hardware (e.g. in xcdroast)
> eds - Enable support for Evolution-Data-Server (EDS)
> +egl - Enable support for EGL OpenGL, necessary on Wayland
> elogind - Enable session tracking via sys-auth/elogind
> emacs - Add support for GNU Emacs
> emboss - Add support for the European Molecular Biology Open Software Suite
> --
> 2.42.0
>
>
--
ionen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag
2023-09-10 18:28 ` [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Ionen Wolkens
@ 2023-09-10 18:42 ` Ionen Wolkens
2023-09-10 19:40 ` Rafael Kitover
0 siblings, 1 reply; 6+ messages in thread
From: Ionen Wolkens @ 2023-09-10 18:42 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 11703 bytes --]
On Sun, Sep 10, 2023 at 02:28:21PM -0400, Ionen Wolkens wrote:
> On Sun, Sep 10, 2023 at 03:45:21PM +0000, Rafael Kitover wrote:
> > Add the egl USE flag and description to profiles/use.desc and remove egl
> > flag descriptions from all ebuild metadata.xml files that contain it.
> >
> > PR: https://github.com/gentoo/gentoo/pull/32452
> >
> > Signed-off-by: Rafael Kitover <rkitover@gmail.com>
> > ---
> > dev-games/ogre/metadata.xml | 1 -
> > dev-games/openscenegraph-openmw/metadata.xml | 1 -
> > dev-games/openscenegraph/metadata.xml | 1 -
> > dev-qt/qtgui/metadata.xml | 1 -
> > media-gfx/openscad/metadata.xml | 3 ---
> > media-libs/clutter/metadata.xml | 1 -
> > media-libs/gst-plugins-bad/metadata.xml | 1 -
> > media-libs/gst-plugins-base/metadata.xml | 1 -
> > media-libs/libepoxy/metadata.xml | 3 ---
> > media-libs/libva-compat/metadata.xml | 1 -
> > media-libs/waffle/metadata.xml | 1 -
> > media-plugins/gst-plugins-gtk/metadata.xml | 1 -
> > media-plugins/gst-plugins-vaapi/metadata.xml | 1 -
> > media-video/mpv/metadata.xml | 1 -
> > profiles/use.desc | 1 +
> > 15 files changed, 1 insertion(+), 18 deletions(-)
>
> That's actually not a lot of ebuilds for a global flag. Not that it is
> an issue per the devmanual (5+).
>
> But in a lot of situations the flag is not particularly needed given
> it can be enabled together with opengl without needing anything special
> (aka just need libglvnd, not a special mesa[egl(+)] check).
Not to say that it does *not* have some real use cases still, so not
necessarily against it if feels it's useful.
>
> In fact, I just removed it on qtbase not long ago, so now it only
> exists on qtgui.
>
> May remove it from mpv eventually too, it should probably be merged
> into IUSE=opengl given IUSE=egl is also used for the "new" opengl
> backend while IUSE=opengl is the deprecated one plus some other obscure
> things.
>
> Tend to feel libepoxy doesn't need the flag and should just enable it
> like mesa did too.
>
> Haven't really looked at the others.
>
> >
> > diff --git a/dev-games/ogre/metadata.xml b/dev-games/ogre/metadata.xml
> > index 10134612ebf8..212b8c99e8fe 100644
> > --- a/dev-games/ogre/metadata.xml
> > +++ b/dev-games/ogre/metadata.xml
> > @@ -86,7 +86,6 @@ Exporters
> > <flag name="deprecated" restrict=">dev-games/ogre-13">
> > Build deprecated nodeless positioning of Lights and Cameras.
> > </flag>
> > - <flag name="egl">Use egl instead of glx</flag>
> > <flag name="fine-granularity" restrict="~dev-games/ogre-2.1">
> > Enable fine light mask granularity. This impacts on performance and should
> > not be enabled unless an application really needs it.
> > diff --git a/dev-games/openscenegraph-openmw/metadata.xml b/dev-games/openscenegraph-openmw/metadata.xml
> > index 26f01f3f105e..95b4405f0657 100644
> > --- a/dev-games/openscenegraph-openmw/metadata.xml
> > +++ b/dev-games/openscenegraph-openmw/metadata.xml
> > @@ -27,7 +27,6 @@
> > <use>
> > <flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
> > <flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
> > - <flag name="egl">Enable EGL support</flag>
> > <flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
> > <flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
> > <flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
> > diff --git a/dev-games/openscenegraph/metadata.xml b/dev-games/openscenegraph/metadata.xml
> > index 88b68f751d28..049f3df3a410 100644
> > --- a/dev-games/openscenegraph/metadata.xml
> > +++ b/dev-games/openscenegraph/metadata.xml
> > @@ -15,7 +15,6 @@
> > <use>
> > <flag name="collada">Enable DAE file support via <pkg>dev-libs/collada-dom</pkg></flag>
> > <flag name="dicom">Enable DICOM medical image file support via <pkg>sci-libs/dcmtk</pkg></flag>
> > - <flag name="egl">Enable EGL support</flag>
> > <flag name="fox">Build examples using <pkg>x11-libs/fox</pkg> library</flag>
> > <flag name="gdal">Enable support for <pkg>sci-libs/gdal</pkg> library</flag>
> > <flag name="las">Enable support for geospatial data LAS LiDAR format using <pkg>sci-geosciences/liblas</pkg></flag>
> > diff --git a/dev-qt/qtgui/metadata.xml b/dev-qt/qtgui/metadata.xml
> > index ab06e044872c..55e237a8d1ef 100644
> > --- a/dev-qt/qtgui/metadata.xml
> > +++ b/dev-qt/qtgui/metadata.xml
> > @@ -6,7 +6,6 @@
> > <name>Gentoo Qt Project</name>
> > </maintainer>
> > <use>
> > - <flag name="egl">Enable EGL integration</flag>
> > <flag name="eglfs">Build the EGL Full Screen/Single Surface platform plugin</flag>
> > <flag name="evdev">Enable support for input devices via evdev</flag>
> > <flag name="ibus">Build the IBus input method plugin</flag>
> > diff --git a/media-gfx/openscad/metadata.xml b/media-gfx/openscad/metadata.xml
> > index 0b965cbf4ac8..72d213f9fe70 100644
> > --- a/media-gfx/openscad/metadata.xml
> > +++ b/media-gfx/openscad/metadata.xml
> > @@ -21,9 +21,6 @@
> > Mac OS X.
> > </longdescription>
> > <use>
> > - <flag name="egl">
> > - Build using EGL instead of GLX
> > - </flag>
> > <flag name="experimental">
> > Enable experimental features
> > </flag>
> > diff --git a/media-libs/clutter/metadata.xml b/media-libs/clutter/metadata.xml
> > index c945cf9a5946..bb66dfa52e7a 100644
> > --- a/media-libs/clutter/metadata.xml
> > +++ b/media-libs/clutter/metadata.xml
> > @@ -6,7 +6,6 @@
> > <name>Gentoo GNOME Desktop</name>
> > </maintainer>
> > <use>
> > - <flag name="egl">Enable EGL backend.</flag>
> > <flag name="gtk">Use gdk-pixbuf from <pkg>x11-libs/gtk+</pkg> as image rendering backend</flag>
> > </use>
> > <upstream>
> > diff --git a/media-libs/gst-plugins-bad/metadata.xml b/media-libs/gst-plugins-bad/metadata.xml
> > index 6749b9b02477..0f38fc62ad85 100644
> > --- a/media-libs/gst-plugins-bad/metadata.xml
> > +++ b/media-libs/gst-plugins-bad/metadata.xml
> > @@ -7,7 +7,6 @@
> > </maintainer>
> > <use>
> > <flag name="bzip2">Enable bzip2 encoder/decoder plugin</flag>
> > - <flag name="egl">Enable EGL support</flag>
> > <flag name="gles2">Enable GLES2 support</flag>
> > <flag name="qsv">Enable Intel Quick Sync Video using the <pkg>media-libs/oneVPL</pkg> dispatcher</flag>
> > </use>
> > diff --git a/media-libs/gst-plugins-base/metadata.xml b/media-libs/gst-plugins-base/metadata.xml
> > index f540928582cf..179c5151b43c 100644
> > --- a/media-libs/gst-plugins-base/metadata.xml
> > +++ b/media-libs/gst-plugins-base/metadata.xml
> > @@ -7,7 +7,6 @@
> > </maintainer>
> > <use>
> > <flag name="gbm">Enable Graphics Buffer Manager based EGL windowing system support (requires egl and at least one of gles or opengl)</flag>
> > - <flag name="egl">Enable EGL platform support</flag>
> > <flag name="gles2">Enable OpenGL library and plugin via GLESv2 API (requires egl)</flag>
> > <flag name="ivorbis">Enable integer based vorbis decoder</flag>
> > <flag name="opengl">Enable OpenGL library and plugin via desktop OpenGL API</flag>
> > diff --git a/media-libs/libepoxy/metadata.xml b/media-libs/libepoxy/metadata.xml
> > index e092005ad115..509b7d255563 100644
> > --- a/media-libs/libepoxy/metadata.xml
> > +++ b/media-libs/libepoxy/metadata.xml
> > @@ -5,9 +5,6 @@
> > <email>x11@gentoo.org</email>
> > <name>X11</name>
> > </maintainer>
> > - <use>
> > - <flag name="egl">Enable EGL support.</flag>
> > - </use>
> > <upstream>
> > <remote-id type="github">anholt/libepoxy</remote-id>
> > </upstream>
> > diff --git a/media-libs/libva-compat/metadata.xml b/media-libs/libva-compat/metadata.xml
> > index e454a2831910..455cac07f59c 100644
> > --- a/media-libs/libva-compat/metadata.xml
> > +++ b/media-libs/libva-compat/metadata.xml
> > @@ -6,7 +6,6 @@
> > <name>James Le Cuirot</name>
> > </maintainer>
> > <use>
> > - <flag name="egl">Enables EGL support.</flag>
> > <flag name="drm">Enables VA/DRM API support.</flag>
> > </use>
> > <upstream>
> > diff --git a/media-libs/waffle/metadata.xml b/media-libs/waffle/metadata.xml
> > index 7d510e7a6781..4ee146af9dcb 100644
> > --- a/media-libs/waffle/metadata.xml
> > +++ b/media-libs/waffle/metadata.xml
> > @@ -6,7 +6,6 @@
> > <name>X11</name>
> > </maintainer>
> > <use>
> > - <flag name="egl">Enable EGL support</flag>
> > <flag name="gbm">Enable support for the Generic Buffer Manager (gbm)</flag>
> > <flag name="wayland">Enable Wayland support</flag>
> > </use>
> > diff --git a/media-plugins/gst-plugins-gtk/metadata.xml b/media-plugins/gst-plugins-gtk/metadata.xml
> > index 7235f1bab7ba..f3b18c11bcfc 100644
> > --- a/media-plugins/gst-plugins-gtk/metadata.xml
> > +++ b/media-plugins/gst-plugins-gtk/metadata.xml
> > @@ -6,7 +6,6 @@
> > <name>GStreamer package maintainers</name>
> > </maintainer>
> > <use>
> > - <flag name="egl">Enable EGL platform usage</flag>
> > <flag name="gles2">Enable gtkglsink OpenGL sink based on GLESv2 API</flag>
> > <flag name="opengl">Enable gtkglsink OpenGL sink based on desktop OpenGL API</flag>
> > </use>
> > diff --git a/media-plugins/gst-plugins-vaapi/metadata.xml b/media-plugins/gst-plugins-vaapi/metadata.xml
> > index 3f726dfa99ea..6997730f1472 100644
> > --- a/media-plugins/gst-plugins-vaapi/metadata.xml
> > +++ b/media-plugins/gst-plugins-vaapi/metadata.xml
> > @@ -7,7 +7,6 @@
> > </maintainer>
> > <use>
> > <flag name="drm">Enable DRM renderer</flag>
> > - <flag name="egl">Enable EGL support</flag>
> > <flag name="gles2">Enable GLESv2 and GLESv3 support</flag>
> > </use>
> > </pkgmetadata>
> > diff --git a/media-video/mpv/metadata.xml b/media-video/mpv/metadata.xml
> > index 7ae1bd6e2875..e6f3a0a8f95c 100644
> > --- a/media-video/mpv/metadata.xml
> > +++ b/media-video/mpv/metadata.xml
> > @@ -10,7 +10,6 @@
> > <flag name="bluray">Enable playback of Blu-ray filesystems</flag>
> > <flag name="cli">Enable the command-line player</flag>
> > <flag name="drm">Enable Kernel Mode Setting / Direct Rendering Manager based video outputs</flag>
> > - <flag name="egl">Enable support for various EGL-based video outputs / backends</flag>
> > <flag name="gamepad">Enable gamepad input support</flag>
> > <flag name="libmpv">Enable the shared library and headers (used by frontends / plugins)</flag>
> > <flag name="libplacebo">Enable support for GPU accelerated video rendering with <pkg>media-libs/libplacebo</pkg></flag>
> > diff --git a/profiles/use.desc b/profiles/use.desc
> > index 6034f3bf6fc3..4a8f5618f7ca 100644
> > --- a/profiles/use.desc
> > +++ b/profiles/use.desc
> > @@ -70,6 +70,7 @@ dvb - Add support for DVB (Digital Video Broadcasting)
> > dvd - Add support for DVDs
> > dvdr - Add support for DVD writer hardware (e.g. in xcdroast)
> > eds - Enable support for Evolution-Data-Server (EDS)
> > +egl - Enable support for EGL OpenGL, necessary on Wayland
> > elogind - Enable session tracking via sys-auth/elogind
> > emacs - Add support for GNU Emacs
> > emboss - Add support for the European Molecular Biology Open Software Suite
> > --
> > 2.42.0
> >
> >
>
> --
> ionen
--
ionen
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag
2023-09-10 18:42 ` Ionen Wolkens
@ 2023-09-10 19:40 ` Rafael Kitover
0 siblings, 0 replies; 6+ messages in thread
From: Rafael Kitover @ 2023-09-10 19:40 UTC (permalink / raw
To: gentoo-dev
Withdrawing this patch after ionen's response and further discussion
on #gentoo-desktop.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-10 19:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-10 15:45 [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Rafael Kitover
2023-09-10 15:45 ` [gentoo-dev] [PATCH 2/2] x11-libs/wxGTK: egl USE flag for OpenGL on Wayland Rafael Kitover
2023-09-10 16:01 ` Sam James
2023-09-10 18:28 ` [gentoo-dev] [PATCH 1/2] profiles: make egl a global USE flag Ionen Wolkens
2023-09-10 18:42 ` Ionen Wolkens
2023-09-10 19:40 ` Rafael Kitover
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox