From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 47EAF15800A for ; Mon, 31 Jul 2023 12:30:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id A38CAE0CA5; Mon, 31 Jul 2023 12:30:22 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 63CC5E0C9D for ; Mon, 31 Jul 2023 12:30:22 +0000 (UTC) Date: Mon, 31 Jul 2023 08:30:18 -0400 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: use CARGO_CRATE_URIS if already available Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20230731104120.275384-1-flow@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rdk07RaHWc0GPliy" Content-Disposition: inline In-Reply-To: <20230731104120.275384-1-flow@gentoo.org> X-Archives-Salt: f332de4d-4855-42cc-aa51-f459c683b46e X-Archives-Hash: b33b3d430df58e1fe604825ae2502a8d --rdk07RaHWc0GPliy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2023 at 12:41:19PM +0200, Florian Schmaus wrote: > With 59dbfb80f748 ("cargo.eclass: Add variable alternative to > $(cargo_crate_uris)") the _cargo_set_crate_uris function was > introduced. This function runs when the elcass is inherited and sets > CARGO_CRATE_URIS. >=20 > Ebuilds that use $(cargo_crate_uris) in SRC_URI will again invoke this > function, even though CARGO_CRATE_URIS is already set. Avoiding this > unnecessary computation reduces the ebuild source time of > app-shells/nushell-0.83.0 from 21 ms to 14 ms. Note that pkgcheck (just) gained a check for this, ebuilds should get fixed in time which would makes this change only an interim thing and imo not all that worth it. Aka: app-shells/nushell$ pkgcheck scan app-shells/nushell SuboptimalCratesSeparator: version 0.82.0: line: 9: using - as name-versi= on separator in CRATES is suboptimal, use name@version instead SuboptimalCratesURICall: version 0.82.0: line: 601: calling '$(cargo_crat= e_uris)' is suboptimal, use '${CARGO_CRATE_URIS}' for global CRATES instead SuboptimalCratesURICall: version 0.83.0: line: 574: calling '$(cargo_crat= e_uris)' is suboptimal, use '${CARGO_CRATE_URIS}' for global CRATES instead --=20 ionen --rdk07RaHWc0GPliy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmTHqVoACgkQskQGsLCs QzTKbQf/ZDms26lLi2JIoUjIHESMoTUu3mIXDvqW5IWYLVGEWarDy2dZUmdJ3yY7 MtVGQwCqGcdofMevzHbq96cqIW9ac1xrDw8Hu9M6s36b1N85uUMYRV1yb1k8YlGU tawtkBhhoS6JcnNdfWSxGG9vENrzxKKvU9HYifZwnhpLJk20syF2kA1HcpZxSK6+ b+YFRdIoXxjr2+/5yT2Rtzge7pQMDhXHPNIL7WWlGhyBEoPrWr3hL+24dYAZvzW+ satUvr+VPMEmxM0LJ3bOz7rp14UkN1dI9Kp1WfEDFPwatoGQ+lRsp6eUGD24rNCm TpGmjb4/OpMLp0ppzGA9x0380gfUZQ== =Puxv -----END PGP SIGNATURE----- --rdk07RaHWc0GPliy--