[gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Sam James]

Ionen pointed this out again today and it made me look back at it; there's
no reason to not have vulkan on by default for desktop profiles.

In particular, Steam expects it for plenty of games to work, but at this point,
it's becoming jarring for users to _not_ have it as it's considered a fundamental part
of the modern desktop.

Signed-off-by: Sam James <sam@gentoo.org>
---
 profiles/targets/desktop/make.defaults | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/profiles/targets/desktop/make.defaults b/profiles/targets/desktop/make.defaults
index 46a8c5d3911e8..caccdbdd22a3e 100644
--- a/profiles/targets/desktop/make.defaults
+++ b/profiles/targets/desktop/make.defaults
@@ -1,4 +1,4 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-USE="a52 aac acpi alsa bluetooth branding cairo cdda cdr cups dbus dri dts dvd dvdr elogind encode exif flac gif gpm gtk gui icu jpeg lcms libnotify mad mng mp3 mp4 mpeg ogg opengl pango pdf png policykit ppds qt5 sdl sound spell startup-notification svg tiff truetype vorbis udev udisks unicode upower usb wxwidgets X xcb xft x264 xml xv xvid"
+USE="a52 aac acpi alsa bluetooth branding cairo cdda cdr cups dbus dri dts dvd dvdr elogind encode exif flac gif gpm gtk gui icu jpeg lcms libnotify mad mng mp3 mp4 mpeg ogg opengl pango pdf png policykit ppds qt5 sdl sound spell startup-notification svg tiff truetype vorbis udev udisks unicode upower usb vulkan wxwidgets X xcb xft x264 xml xv xvid"
-- 
2.40.1

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Ulrich Mueller]

>>>>> On Sun, 21 May 2023, Sam James wrote:

> Ionen pointed this out again today and it made me look back at it;
> there's no reason to not have vulkan on by default for desktop
> profiles.

That's a non-sequitur. No reason to not have it on doesn't imply that
there is a reason to have it on.

Also, shouldn't we avoid enabling local flags in profiles?

> In particular, Steam expects it for plenty of games to work,

That's what USE dependencies are for.

Ulrich

[gentoo-dev] Re: [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[David Seifert]

On Sun, 2023-05-21 at 22:48 +0100, Sam James wrote:
> Ionen pointed this out again today and it made me look back at it;
> there's
> no reason to not have vulkan on by default for desktop profiles.
> 
> In particular, Steam expects it for plenty of games to work, but at
> this point,
> it's becoming jarring for users to _not_ have it as it's considered a
> fundamental part
> of the modern desktop.
> 
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  profiles/targets/desktop/make.defaults | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/profiles/targets/desktop/make.defaults
> b/profiles/targets/desktop/make.defaults
> index 46a8c5d3911e8..caccdbdd22a3e 100644
> --- a/profiles/targets/desktop/make.defaults
> +++ b/profiles/targets/desktop/make.defaults
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2022 Gentoo Authors
> +# Copyright 1999-2023 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
> -USE="a52 aac acpi alsa bluetooth branding cairo cdda cdr cups dbus
> dri dts dvd dvdr elogind encode exif flac gif gpm gtk gui icu jpeg
> lcms libnotify mad mng mp3 mp4 mpeg ogg opengl pango pdf png policykit
> ppds qt5 sdl sound spell startup-notification svg tiff truetype vorbis
> udev udisks unicode upower usb wxwidgets X xcb xft x264 xml xv xvid"
> +USE="a52 aac acpi alsa bluetooth branding cairo cdda cdr cups dbus
> dri dts dvd dvdr elogind encode exif flac gif gpm gtk gui icu jpeg
> lcms libnotify mad mng mp3 mp4 mpeg ogg opengl pango pdf png policykit
> ppds qt5 sdl sound spell startup-notification svg tiff truetype vorbis
> udev udisks unicode upower usb vulkan wxwidgets X xcb xft x264 xml xv
> xvid"

Agreed, vulkan is absolutely needed on a modern desktop.

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Ionen Wolkens]

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

On Mon, May 22, 2023 at 10:13:59AM +0200, Ulrich Mueller wrote:
> >>>>> On Sun, 21 May 2023, Sam James wrote:
> 
> > Ionen pointed this out again today and it made me look back at it;
> > there's no reason to not have vulkan on by default for desktop
> > profiles.
> 
> That's a non-sequitur. No reason to not have it on doesn't imply that
> there is a reason to have it on.
> 
> Also, shouldn't we avoid enabling local flags in profiles?

I keep forgetting that this is still not global either, guess it'll
ideally need another step first.
 
> 
> > In particular, Steam expects it for plenty of games to work,
> 
> That's what USE dependencies are for.

For often-used USE, that doesn't mean that every users should have to
enable it manually when they try to emerge the package. It would
notably be annoying if, e.g. opengl wasn't default either (if opengl
can be a default, I don't see why vulkan can't be in 2023).

I see this as a sane desktop default much like having png, jpeg, etc..
enabled.

Steam, games, and similar applications also come from several sources
not necessarily managed by portage all while expecting typical GPU
features (and png/jpeg support!) to work without having to dig in
USE flags on a desktop profile more than necessary. It's a better
out-of-the-box user experience.

Vulkan dependencies are also fairly trivial, typically it's just about
pulling vulkan-loader, headers, and glslang plus having support on mesa
or nvidia-drivers (always enabled regardless for the latter).
-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Ulrich Mueller]

>>>>> On Mon, 22 May 2023, Ionen Wolkens wrote:

>> That's a non-sequitur. No reason to not have it on doesn't imply that
>> there is a reason to have it on.
>> 
>> Also, shouldn't we avoid enabling local flags in profiles?

> I keep forgetting that this is still not global either, guess it'll
> ideally need another step first.

I see vulkan 31 times in use.local.desc, with slightly different
descriptions. Most notable difference:

app-office/libreoffice:vulkan - Enable Vulkan usage via the skia library (clang recommended)

Should it be renamed to "skia" for libreoffice, because that's also the
name of the upstream flag? libreoffice will also output a warning with
USE="vulkan -clang".

> For often-used USE, that doesn't mean that every users should have to
> enable it manually when they try to emerge the package. It would
> notably be annoying if, e.g. opengl wasn't default either (if opengl
> can be a default, I don't see why vulkan can't be in 2023).

> I see this as a sane desktop default much like having png, jpeg, etc..
> enabled.

Right, this is a valid reason for enabling it.

> Steam, games, and similar applications also come from several sources
> not necessarily managed by portage all while expecting typical GPU
> features (and png/jpeg support!) to work without having to dig in
> USE flags on a desktop profile more than necessary. It's a better
> out-of-the-box user experience.

IMHO this isn't. It is at least debatable if unpackaged proprietary
software should have any influence on our default settings.

Ulrich

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Andreas Sturmlechner]

[-- Attachment #1: Type: text/plain, Size: 549 bytes --]

On Montag, 22. Mai 2023 12:36:22 CEST Ulrich Mueller wrote:
> 
> app-office/libreoffice:vulkan - Enable Vulkan usage via the skia library
> (clang recommended)
> 
> Should it be renamed to "skia" for libreoffice, because that's also the
> name of the upstream flag? libreoffice will also output a warning with
> USE="vulkan -clang".

That would not be accurate. The (bundled) skia is always being built, it is 
just the component using vulkan. That detail does not need to be part of the 
description though, so a global would fit.

Regards,
Andreas

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 789 bytes --]

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Ulrich Mueller]

>>>>> On Mon, 22 May 2023, Andreas Sturmlechner wrote:

>> Should it be renamed to "skia" for libreoffice, because that's also the
>> name of the upstream flag? libreoffice will also output a warning with
>> USE="vulkan -clang".

> That would not be accurate. The (bundled) skia is always being built,
> it is just the component using vulkan. That detail does not need to be
> part of the description though, so a global would fit.

Why is it "$(use_enable vulkan skia)" in econf arguments then?

configure --help says:

  --disable-skia          Disable building Skia. Use --enable-skia=debug to
                          build without optimizations.

Ulrich

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[orbea]

On Sun, 21 May 2023 22:48:50 +0100
Sam James <sam@gentoo.org> wrote:

> Ionen pointed this out again today and it made me look back at it;
> there's no reason to not have vulkan on by default for desktop
> profiles.

Its not supported in nouveau yet.

Re: [gentoo-dev] [PATCH] profiles/targets/desktop: enable USE=vulkan by default

[Ionen Wolkens]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On Mon, May 22, 2023 at 05:54:05AM -0700, orbea wrote:
> On Sun, 21 May 2023 22:48:50 +0100
> Sam James <sam@gentoo.org> wrote:
> 
> > Ionen pointed this out again today and it made me look back at it;
> > there's no reason to not have vulkan on by default for desktop
> > profiles.
> 
> Its not supported in nouveau yet.

Older cards won't support it either (e.g. my 560ti doesn't), that's
not really a problem as far as enabling it and being usable for most
people goes. At most it's just a few not-useful dependencies by default
like having libwayland when you use Xorg.
-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]