From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 8D1F815813A for ; Mon, 13 Jan 2025 16:11:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3AECDE0817; Mon, 13 Jan 2025 16:11:04 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 21F34E07D7 for ; Mon, 13 Jan 2025 16:11:03 +0000 (UTC) Date: Mon, 13 Jan 2025 11:10:59 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: Emit a warning if the package uses 300+ crates Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20250112125639.15047-1-mgorny@gentoo.org> <8e3840b5-acc5-43ff-908f-660baae13163@gentoo.org> <20250113052354.4bfc2973@Akita> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6pucyPt8LyxGU085" Content-Disposition: inline In-Reply-To: <20250113052354.4bfc2973@Akita> X-Archives-Salt: 0f9a1811-4c74-455c-82ed-74c6f0a27c42 X-Archives-Hash: e2ace625ecce49ac8a1f56d7b6925b87 --6pucyPt8LyxGU085 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 13, 2025 at 05:23:54AM -0800, orbea wrote: > On Mon, 13 Jan 2025 10:40:30 +0100 > Florian Schmaus wrote: >=20 > > On 12/01/2025 13.56, Micha=C5=82 G=C3=B3rny wrote: > > > Emit a QA warning suggesting the use of crate tarball, when the > > > package in question uses 300 crates or more. Such a long crate > > > lists cause ebuilds and Manifests to grow very fast, causing > > > significant space consumption on end user systems (including users > > > who are not using the package in question) and git history growth. > > > On top of that, fetching that many crates takes significant time. > > >=20 > > > The number of 300 is pretty arbitrary, chosen approximately to match > > > Manifests that are over 100 KiB in size. We should probably look > > > into lowering in the future, as more packages are transitioned. =20 > > Thanks for your proposal. I know you wrote it because Gentoo is=20 > > important to you. > >=20 > > I am sorry, however, but the arbitrary limit you propose is harmful, > > and its necessity is questionable. >=20 > Its worth pointing out that is already being done in Gentoo, see > dev-util/maturin for one example. ftr this is something I was planning to do either way, but kept procrastinating given that package needs special handling to handle crates used by tests (it builds separate rust packages for its tests with their own crates). This just prompted me to finally have a look before a potential warning hits. --=20 ionen --6pucyPt8LyxGU085 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmeFOxMACgkQskQGsLCs QzSvfwgAqzqF0A5uqUvDoWRmsM8/nhMLAVBB+Ul1liXYjBTExmxGp3MD70IZm7Wl 5uoVtdl6MthvPXo5lKBIlrr8eiOTXxBUZW8g5Gy9Dzw0l4RI2zC4S02aheDwUl1U PuitWwgqJwIKdZ4DwAIPgjALhGiMOx03Ly6XQQ/s84iURehkLIVt07MRF/8kHmQq i49LD4R+teYLFDqAWIH+DDf3+ZcN7tqERTojYRCjG2xW4IXeYqSdK4AebYq7yG0L 23fZwjBpiRl8vOrPBvx+ipqNjowL4Nqz4X/tsyXS5wBWo+M38z7BjpHUdI+wdR9p peUx5z3Ig2/zprrtLumtpoPL8YFCQQ== =t83G -----END PGP SIGNATURE----- --6pucyPt8LyxGU085--