Re: [gentoo-dev] [PATCH] cargo.eclass: Emit a warning if the package uses 300+ crates

[Ionen Wolkens <ionen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]

On Sun, Jan 12, 2025 at 02:30:10PM +0000, Alexey Sokolov wrote:
> 12.01.2025 13:15, Agostino Sarubbo пишет:
> 
> > On domenica 12 gennaio 2025 13:56:39 CET Michał Górny wrote:
> >
> >> + if [[ ${#crates[@]} -ge 300 ]]; then
> >
> >> + eqawarn "This package uses a very large number of
> >
> >> CRATES. Please provide" + eqawarn "a crate tarball
> >
> >> instead and fetch it via SRC_URI. You can use" +
> >
> >> eqawarn "'pycargoebuild --crate-tarball' to create one." + fi
> >
> > I would like to suggest to use "QA Notice: " prefix if you want to have them reported.
> >
> > Agostino
> 
> Side question: maybe eqawarn should add such prefix automatically?
In the context of automatically filing bugs, sometimes we also want to
warn for low priority things (e.g. either just something to be aware of
or something to ideally fix on bump when happen to see the warning)
without filing a hundred bugs.

So question is more whether we want this to happen here or not and put
pressure on maintainers (incl. proxied) to fix it asap.

From a technical standpoint, eqawarn would need to know when it's the
"header" of a notice (like optfeature_header) given we often have
several eqawarn in a row and "QA Notice:" for each line would be weird.
This means needing to modify all usage of it anyway which doesn't bring
much vs just inlining it unless we wanted to do something more special
with this.
-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]