From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2794F15812D for ; Tue, 31 Dec 2024 02:31:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E2A3AE0794; Tue, 31 Dec 2024 02:31:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A98A1E077C for ; Tue, 31 Dec 2024 02:31:25 +0000 (UTC) Date: Mon, 30 Dec 2024 21:31:21 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Cc: James Le Cuirot Subject: Re: [gentoo-dev] [PATCH] toolchain.eclass: Fix strip exclusion for prefixed cross-compilers Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org, James Le Cuirot References: <20241230233544.2802-1-chewi@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ERH5E/9E1MZwTsu9" Content-Disposition: inline In-Reply-To: <20241230233544.2802-1-chewi@gentoo.org> X-Archives-Salt: 813b9f5a-353c-4d94-ac9f-fe54bba20be8 X-Archives-Hash: b8539db21195298d2d0c341171495e0a --ERH5E/9E1MZwTsu9 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 30, 2024 at 11:35:25PM +0000, James Le Cuirot wrote: > dostrip limitations mean that we cannot strip the CTARGET binaries in a > cross-compiler. There is already a `dostrip -x` call to exclude such > binaries from stripping, but it expects the argument to be unprefixed, > and the argument given was prefixed. >=20 > Signed-off-by: James Le Cuirot > --- > eclass/toolchain.eclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass > index 602f994371452..486b5877be66d 100644 > --- a/eclass/toolchain.eclass > +++ b/eclass/toolchain.eclass > @@ -2641,7 +2641,7 @@ toolchain_src_install() { > # - "${D}${LIBPATH}" > # As dostrip does not specify host to override ${CHOST} tools just skip > # non-native binary stripping. > - is_crosscompile && dostrip -x "${LIBPATH}" > + is_crosscompile && dostrip -x "${LIBPATH#${EPREFIX}}" Missing quotes in case of unlikely globs in EPREFIX "${LIBPATH#"${EPREFIX}"}" > =20 > cd "${S}" || die > if is_crosscompile; then > --=20 > 2.47.1 >=20 >=20 --=20 ionen --ERH5E/9E1MZwTsu9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmdzV3kACgkQskQGsLCs QzRGEwf6AxgAdDKRcm4667SN7r4hVpGdZtx9X6jQypTupeQRAZAtPGJgFNVz8Tba OqrFAEOL3N1NjI8evy8cst/zcF1uWA1meIRVe/4A2sv7r0Qvkm6/TcCExIUqjgX1 NlESeRHwQ9DrN0k3/pSQIVU3rJ+EVRGl2b5UlpjV1PWKYzvzW8xsJKE4xW5XCKq0 HSbJdjJtgRv1dC8rENxtEIenaXmRNqdmFQhu6ebK+wYevrIB88dPfZ6aCC+Ibedn zDsQ2g/Csk6xcVdt8OROOKA1yMXfqSRiUPh9+EMibgM9/NbDp8GMP5io6i4oN7JI 5QP5ow/Mj7QDXWsYX4z6FB2Gt/cAUA== =bZgj -----END PGP SIGNATURE----- --ERH5E/9E1MZwTsu9--