From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 2ED21158091 for ; Fri, 3 Jun 2022 14:13:17 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 410B8E093E; Fri, 3 Jun 2022 14:13:10 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9A548E0918 for ; Fri, 3 Jun 2022 14:13:09 +0000 (UTC) Date: Fri, 3 Jun 2022 10:13:05 -0400 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH v2 0/1] esed Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <20220531112319.29168-1-ionen@gentoo.org> <20220603113646.25973-1-ionen@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gKHn64OgXRfDaxzz" Content-Disposition: inline In-Reply-To: <20220603113646.25973-1-ionen@gentoo.org> X-Archives-Salt: 50e11261-ab45-4731-a28d-a9ea8cd8e094 X-Archives-Hash: 3fc7508d046b8c262d95199e40093c70 --gKHn64OgXRfDaxzz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 03, 2022 at 07:36:45AM -0400, Ionen Wolkens wrote: > Nothing fundamentally different until further feedback, > mostly to get eval out of the way. >=20 > Changelog > v2: > - replace use of eval (realized another way works) > - add missing quotes around one _esed_output > - move diff checks inside comparison blocks For the record, more work planned so please wait for v3 for further review (may be a bit), albeit any feedback / ideas welcome. Right now looking at: - some enewsed fixes or perhaps reimplementation (noticed a meh flaw) - adding a pure bash non-sed replacer suggested by mgorny, e.g. erepl this would be useful to use for simple operations not crippled by sed delimiters, and generally preferable unless need fancy sed stuff - perhaps cut support for some unlikely-anyone-will-need features, like at least `sed s/// file1 file2 > file3` concat, and perhaps requiring files to be always at end of command line or others things which may help simplify (without going full minimal, erepl will be for that). >=20 > Ionen Wolkens (1): > esed.eclass: new eclass >=20 > eclass/esed.eclass | 201 +++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 201 insertions(+) > create mode 100644 eclass/esed.eclass >=20 > --=20 > 2.35.1 >=20 >=20 --=20 ionen --gKHn64OgXRfDaxzz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmKaFvEACgkQskQGsLCs QzS6CwgAmL83rLK/9yLzlgg0NslrMcUkKk+cZdOnJkea5qNVsrPc/RTZvpmiZY76 9WRPletwjjW4P0h8uvst0pgRquN0UdEIS/Ch72e2qCQjGzxLHYHCHSiey+Vq/2v5 zi+h2b6rqps+bQG+LVD/LaR0rV/xixdWrSJ8OSlN2G+WI+zQyEq9MzHMxoUJgGg8 CpU8wyBEDDFczH6oY8cdtheN6jv2uCesHdI066VLma7kDaJs2gZKFoRckF1fFrz9 0XIEaa70jdBdcbcikmWN9B8/04KPL9+NOj52Oimr8fZmcSSJGMxDZxy8rbn3ujML gQpeZMaaj+04PRYEpUMfSb3hBNMY/g== =LL4r -----END PGP SIGNATURE----- --gKHn64OgXRfDaxzz--