public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ionen Wolkens <ionen@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH v2 0/1] esed
Date: Fri, 3 Jun 2022 10:13:05 -0400	[thread overview]
Message-ID: <YpoW8X4oymq+fmDd@eversor> (raw)
In-Reply-To: <20220603113646.25973-1-ionen@gentoo.org>

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

On Fri, Jun 03, 2022 at 07:36:45AM -0400, Ionen Wolkens wrote:
> Nothing fundamentally different until further feedback,
> mostly to get eval out of the way.
> 
> Changelog
> v2:
>  - replace use of eval (realized another way works)
>  - add missing quotes around one _esed_output
>  - move diff checks inside comparison blocks

For the record, more work planned so please wait for v3 for
further review (may be a bit), albeit any feedback / ideas welcome.

Right now looking at:
- some enewsed fixes or perhaps reimplementation (noticed a meh flaw)
- adding a pure bash non-sed replacer suggested by mgorny, e.g. erepl
  this would be useful to use for simple operations not crippled by sed
  delimiters, and generally preferable unless need fancy sed stuff
- perhaps cut support for some unlikely-anyone-will-need features,
  like at least `sed s/// file1 file2 > file3` concat, and perhaps
  requiring files to be always at end of command line or others
  things which may help simplify (without going full minimal, erepl
  will be for that).

> 
> Ionen Wolkens (1):
>   esed.eclass: new eclass
> 
>  eclass/esed.eclass | 201 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 201 insertions(+)
>  create mode 100644 eclass/esed.eclass
> 
> -- 
> 2.35.1
> 
> 

-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2022-06-03 14:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 11:23 [gentoo-dev] [PATCH 0/2] Add esed.eclass for sed that dies if caused no changes Ionen Wolkens
2022-05-31 11:23 ` [gentoo-dev] [PATCH 1/2] esed.eclass: new eclass Ionen Wolkens
2022-05-31 13:45   ` Ionen Wolkens
2022-06-03  7:14   ` Ulrich Mueller
2022-06-03  9:26     ` Ionen Wolkens
2022-06-03 11:19       ` Ionen Wolkens
2022-05-31 11:23 ` [gentoo-dev] [PATCH 2/2] eclass/tests/esed.sh: basic tests for esed.eclass Ionen Wolkens
2022-05-31 13:54 ` [gentoo-dev] [PATCH 0/2] Add esed.eclass for sed that dies if caused no changes Anna
2022-05-31 14:29   ` Ionen Wolkens
2022-05-31 14:44     ` Jaco Kroon
2022-06-03  4:09 ` Michał Górny
2022-06-03  4:45   ` Ionen Wolkens
2022-06-03  4:47     ` Anna V
2022-06-03  5:01       ` Ionen Wolkens
2022-06-03  5:00     ` Anna V
2022-06-03  5:05   ` Ionen Wolkens
2022-06-03  4:59 ` Sam James
2022-06-03  5:02   ` Sam James
2022-06-03 11:36 ` [gentoo-dev] [PATCH v2 0/1] esed Ionen Wolkens
2022-06-03 11:36   ` [gentoo-dev] [PATCH v2 1/1] esed.eclass: new eclass Ionen Wolkens
2022-06-04  0:15     ` Oskari Pirhonen
2022-06-04  7:00       ` Ionen Wolkens
2022-06-03 14:13   ` Ionen Wolkens [this message]
2022-06-04 16:19 ` [gentoo-dev] [PATCH 0/2] Add esed.eclass for sed that dies if caused no changes Alessandro Barbieri
2022-06-04 16:53   ` Ionen Wolkens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpoW8X4oymq+fmDd@eversor \
    --to=ionen@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox