From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5AB4815808B for ; Wed, 16 Feb 2022 22:21:39 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8C273E0826; Wed, 16 Feb 2022 22:21:33 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1CFE1E079E for ; Wed, 16 Feb 2022 22:21:33 +0000 (UTC) Date: Wed, 16 Feb 2022 17:21:29 -0500 From: Ionen Wolkens To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] cmake.eclass: Fix MYCMAKEARGS breakage with >=dev-util/cmake-3.23 Message-ID: Mail-Followup-To: gentoo-dev@lists.gentoo.org References: <2181564.vFx2qVVIhK@tuxbrain> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+pU+pE/ifSX/w4be" Content-Disposition: inline In-Reply-To: <2181564.vFx2qVVIhK@tuxbrain> X-Archives-Salt: b5bc19ee-7ee3-4d23-ab0d-29ce1a36e966 X-Archives-Hash: 296106734bca8a65dba15617bbc98636 --+pU+pE/ifSX/w4be Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 16, 2022 at 06:58:20PM +0100, Andreas Sturmlechner wrote: > I'm not sure what this variable is about, but we gotta fix it. Mentioned this in the bug too, but it's like MYMESONARGS and EXTRA_ECONF. Not documented but it's still spread around by word of mouth and sometime used by devs too when asking users to try options ("does it work with MYCMAKEARGS=3D-DFIX emerge ...") Any ebuilds using it directly (e.g. pcsx2) is a bug. > ...and rather drop on next EAPI bump. May result in some annoyed users that will ask for it back, not that I think the use is that widespread unlike EXTRA_ECONF. > - "${MYCMAKEARGS}" > ) > =20 > + if [[ -n ${MYCMAKEARGS} ]] ; then > + cmakeargs+=3D( "${MYCMAKEARGS}" ) > + fi > + Better fix would've been to remove the quotes I think, so that it splits arguments and doesn't pass a literal empty "" string. i.e. users could MYCMAKEARGS=3D"-DARG1=3Dyes -DARG2=3Dno" through package.e= nv --=20 ionen --+pU+pE/ifSX/w4be Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEx3SLh1HBoPy/yLVYskQGsLCsQzQFAmINeOkACgkQskQGsLCs QzSX9AgAs73SilFaDlRs2R0My/SmYhtAkI0dLsPWVNoORoeD9ebtfAAzO0txbf9g FacwV+Wwh7JvdrISJ3xyLWBXU9Twt1DRdu9zSYzls/CmD89saZyXYHdn0b0AVF3p D/MQDga36rdPhnqVL6tfuZ2Qp4Uoghc7qinYrI+PS/5oJYNd8Z/Heubj3qgxzMs0 aHwtLzWjtO7Uf6L/YXZpj/PHs0UemdsREE/MKKvZuYfjbcSRn4DulqsR+paKdzZD bKgWJVEfJ3+gUPOMHTLqTxMtXXYE0ekr0BVQi2uLnulnByeyGVffcKATgB27M0/Y pyEtSf77OyqjhsOd34gTWo+H8OprUg== =siaq -----END PGP SIGNATURE----- --+pU+pE/ifSX/w4be--