Re: [gentoo-dev] [PATCH] cmake.eclass: Fix MYCMAKEARGS breakage with >=dev-util/cmake-3.23

[Ionen Wolkens <ionen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On Wed, Feb 16, 2022 at 06:58:20PM +0100, Andreas Sturmlechner wrote:
> I'm not sure what this variable is about, but we gotta fix it.

Mentioned this in the bug too, but it's like MYMESONARGS and
EXTRA_ECONF. Not documented but it's still spread around by
word of mouth and sometime used by devs too when asking users
to try options ("does it work with MYCMAKEARGS=-DFIX emerge ...")

Any ebuilds using it directly (e.g. pcsx2) is a bug.

> ...and rather drop on next EAPI bump.

May result in some annoyed users that will ask for it back, not
that I think the use is that widespread unlike EXTRA_ECONF.

> -		"${MYCMAKEARGS}"
>  	)
>  
> +	if [[ -n ${MYCMAKEARGS} ]] ; then
> +		cmakeargs+=( "${MYCMAKEARGS}" )
> +	fi
> +

Better fix would've been to remove the quotes I think, so that it
splits arguments and doesn't pass a literal empty "" string.

i.e. users could MYCMAKEARGS="-DARG1=yes -DARG2=no" through package.env

-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]