From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 01521158087 for ; Wed, 19 Jan 2022 06:35:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C92C42BC01C; Wed, 19 Jan 2022 06:35:29 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4FA2D2BC00C for ; Wed, 19 Jan 2022 06:35:28 +0000 (UTC) Received: by smtp.gentoo.org (Postfix, from userid 559) id 94A30342E3D; Wed, 19 Jan 2022 06:35:26 +0000 (UTC) Date: Wed, 19 Jan 2022 01:35:27 -0500 From: Mike Frysinger To: Sam James Cc: gentoo-dev@lists.gentoo.org, cross@gentoo.org, base-system@gentoo.org, chewi@gentoo.org Subject: [gentoo-dev] Re: [PATCH 1/4] autotools.eclass: don't inject -I${SYSROOT} to aclocal Message-ID: Mail-Followup-To: Sam James , gentoo-dev@lists.gentoo.org, cross@gentoo.org, base-system@gentoo.org, chewi@gentoo.org References: <20220117110950.139015-1-sam@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KidoNUvgMTb+puXJ" Content-Disposition: inline In-Reply-To: <20220117110950.139015-1-sam@gentoo.org> X-Archives-Salt: b481b740-101c-46fb-8d8f-2fcac3e9c2cf X-Archives-Hash: 319a193517edb67af1624e0da1cb1672 --KidoNUvgMTb+puXJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 17 Jan 2022 11:09, Sam James wrote: > When -I${SYSROOT} is injected, it'll override the default of -Im4, which > results in trying to install macros to ${SYSROOT} (a sandbox violation) > when they can't be found. >=20 > From aclocal(1): > ``` > -I DIR add directory to search list for .m4 files >=20 > --install > copy third-party files to the first -I directory > ``` >=20 > The first directry is normally -Im4 if anything, whereas when injected > (when ${SYSROOT} is defined), it ends up being ${SYSROOT}, not m4 (so > we try to copy macros to somewhere outside of the build directory). we should define the semantics we want and bring it upstream to get into automake. although it seems like ACLOCAL_PATH might work well enough for us now to switch to that. as a stop gap, it seems like the use of --install is pretty low ? we're cross-compiling about ~2.5k packages in CrOS every day and never seen a failure here. so the few packages which are running into troubles can workaround it by setting AT_SYS_M4DIR right ? > In EAPI 7+, this is almost always the case! We don't generally expect > to find macros (particularly things like autoconf-archive) in ${SYSROOT} > because that's for DEPEND-class dependencies, then they end up being > copied in unnecessarily and wrongly. i think this optimism is misplaced. libraries often install m4 files which is precisely why this logic is in here. https://bugs.gentoo.org/677002#c10 deleting this check will break things. prob more than we're fixing. -mike --KidoNUvgMTb+puXJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmHnsS8ACgkQQWM7n+g3 9YEbTxAA0QIj1tp9l+pjjyF8CVv6vJqZJKMoeP0kxQOSvmBF1rmNnv3c/F4ema/L tqwY+vFLHzH8W18rlweG+cDWPHb5NQR8JcsayfTbeWf67YiVOBXuA7GuqTwpgOl9 rFeV8ONyCsHEyYGYSQLzcdkKWIreEjAYRkmUNFX0jpcj2lpcGSClv57zdM0N4g6Q kTi4pD3pihOKBucsnxEnF3tIpo/Oq3jzFInjhXq7AyLTJW5i7eN7opACq/Dh69Zu RBcSOy+UsnsAmwa2VA2VqnVqdT/GtzimheWhvHkhrTTA1HGHgvStitN3Ti4+sewe rEglDeWwhNMvN2PDThComSB8cBFfVIwXH5GmJjoeDslqGsI0zOk8Mm0y1dyIAnSk mOza5kQ7R2MsgMw76X3yD9kTTm6w/ouwV2jhYP5Ni5IPaYZGyhMkHrp9ZRIupgaB MPJ9vqbsomVA4MEpGnnqsvQZP8u+9lDuO5E1CCHpPl2gxJcxnvkKZKxNJqTkTk39 FH0doVWx4jTlezY23J06kwaUork77kpvWvbtXWNF6nBbC7h9ckC3n3wSLrGxfA0Z HtqAknREFYKRG2+ebcujgmJm3tgl4uj30Z+CRV4mqOU8/kCRNQxxzjvo3t4oPZZz xHutyWw1xmDQGzTcDc+0LLkBiHJ+rZEsaG3dwgjUEYB0Jys9CNQ= =WQpJ -----END PGP SIGNATURE----- --KidoNUvgMTb+puXJ--