Re: [gentoo-dev] [PATCH] 2021-11-23-mariadb-database-restore-maybe-required: add item

[Ionen Wolkens <ionen@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1350 bytes --]

On Fri, Nov 26, 2021 at 12:55:10AM +0000, Sam James wrote:
> 
> 
> > On 25 Nov 2021, at 17:07, Thomas Deutschmann <whissi@gentoo.org> wrote:
> > 
> > On 2021-11-25 18:01, Piotr Karbowski wrote:
> >>> https://github.com/gentoo/gentoo/blob/master/sys-libs/glibc/glibc-2.34-r2.ebuild#L643
> >> Would you see something like this on more ebuilds, postgres, mysql, elasticsearch, or have proper FEATURE flag for it instead?
> >> It's all cool and giggles until you realize that even such random variable is not even prefixed with PORTAGE_ or anything, meaning it could be taken out of shell and meant for entirely different thing.
> > 
> > Yeah, sounds like the I_KNOW_WHAT_I_AM_DOING thing which you end up having enabled globally for various reasons.
> 
> Just like updating in a cron job is a not-great idea, setting this globally and not per-package via /etc/portage/env sounds rather cavalier.

Generally I don't think there should be a central catch-all variable for
this, ebuilds should use their own unlikely variable as needed if using
this route until a better solution.

e.g. MARIADB_I_ALLOW_THE_DESTRUCTION_OF_MY_DATABASE=yes

Could take it further and require that =yes be =${PV} so that it only
works once if forgotten.

Then users setting this in not-so-great ways are still unlikely to be
bitten by it.
-- 
ionen

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]